Skip to content

Add missing urls for hash modules #36961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2016
Merged

Add missing urls for hash modules #36961

merged 1 commit into from
Oct 15, 2016

Conversation

GuillaumeGomez
Copy link
Member

@steveklabnik
Copy link
Member

@bors: delegate @kmcallister

@steveklabnik
Copy link
Member

@bors: delegate=@kmcallister

@bors
Copy link
Collaborator

bors commented Oct 6, 2016

✌️ @@kmcallister can now approve this pull request

@steveklabnik
Copy link
Member

@bors: delegate=kmcallister

ugh i should learn how to use bors

@bors
Copy link
Collaborator

bors commented Oct 6, 2016

✌️ @kmcallister can now approve this pull request

kmcallister
kmcallister reviewed Oct 6, 2016
View reviewed changes
src/libcore/hash/mod.rs
///
/// [`Eq`]: cmp/trait.Eq.html
/// [`HashMap`]: ../collections/struct.HashMap.html
/// [`HashSet`]: ../collections/struct.HashSet.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these links will be broken on the libcore docs.

kmcallister
kmcallister reviewed Oct 6, 2016
View reviewed changes
src/libcore/hash/mod.rs
#[stable(feature = "rust1", since = "1.0.0")]
fn write(&mut self, bytes: &[u8]);

/// Write a single `u8` into this hasher
/// Write a single `u8` into this hasher.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the tense mismatch between Writes above and Write here?

@GuillaumeGomez
Copy link
Member Author

Updated (waiting for url check...).

@frewsxcv
Copy link
Member

@bors r+ rollup

@frewsxcv
Copy link
Member

Oh just kidding. The delegate was for @kmcallister. Will let them r+.

@GuillaumeGomez
Copy link
Member Author

@bors: r=frewsxcv rollup

@bors
Copy link
Collaborator

bors commented Oct 13, 2016

📌 Commit 00098bd has been approved by frewsxcv

@bors
Copy link
Collaborator

bors commented Oct 13, 2016

⌛ Testing commit 00098bd with merge 748f8f7...

bors added a commit that referenced this pull request Oct 13, 2016
@bors
Auto merge of #36961 - GuillaumeGomez:hash_doc, r=frewsxcv
748f8f7 
Add missing urls for hash modules

r? @steveklabnik
@alexcrichton
Copy link
Member

@bors: retry force clean

1 similar comment
@alexcrichton
Copy link
Member

@bors: retry force clean

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 14, 2016
Rollup merge of rust-lang#36961 - GuillaumeGomez:hash_doc, r=frewsxcv
ad40a42 
Add missing urls for hash modules

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Oct 14, 2016
Merged
bors added a commit that referenced this pull request Oct 14, 2016
@bors
Auto merge of #37170 - jonathandturner:rollup, r=jonathandturner
a8d189a 
Rollup of 10 pull requests

- Successful merges: #36307, #36755, #36961, #37102, #37115, #37119, #37122, #37123, #37141, #37159
- Failed merges:
@bors bors merged commit 00098bd into rust-lang:master Oct 15, 2016
@GuillaumeGomez GuillaumeGomez deleted the hash_doc branch October 15, 2016 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmcallister kmcallister kmcallister left review comments

Assignees

@steveklabnik steveklabnik

@kmcallister kmcallister

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @steveklabnik @bors @frewsxcv @alexcrichton @kmcallister