Add new error code tests

[GuillaumeGomez]

r? @jonathandturner

[sophiajt]

In case anyone is wondering - I'm using these to make sure we have coverage as we convert the new error codes. After we're done, it probably makes sense for these to live in their own directory in compile-fail

[sophiajt]

@bors r+

[bors]

📌 Commit fb2d940 has been approved by jonathandturner

[nagisa]

Won’t these essentially duplicate existing tests?

[GuillaumeGomez]

@bors: r-

[GuillaumeGomez]

@nagisa: It's for #35233.

[GuillaumeGomez]

Updated (some errors have disappear or be replaced).

[nagisa]

I know what it is for. I'm wondering if there aren't already a test that
could be recycled for this. I'm pretty sure we already have a bunch o tests
for various error codes and messages.

On Aug 4, 2016 2:37 PM, "Guillaume Gomez" [email protected] wrote:

@nagisa https://github.com/nagisa: It's for #35233
#35233.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#35274 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApc0hmV9klS_uT9AbBMinzAEkzMFScGks5qcc7kgaJpZM4JcNdQ
.

[GuillaumeGomez]

@nagisa: They are, but they rarely target a specific error code.

[sophiajt]

@nagisa - there may already be a tested, but it's difficult to see what our coverage is without literally searching for each error code.

One possibly future fix would be to include the error code in the unit test filename, so that we can see error codes that aren't being checked. I noticed quite a few don't have tests that only got them because of @GuillaumeGomez's work.

We can also put them in a separate directory under compile-fail just like the borrowck errors, so they're not in the way, but I want to wait to do that until after people have updated them.

[sophiajt]

I'm seeing a lot of error codes without any tests. You'd think this would be duplicating work, and it probably will in some cases, but I think coverage is more important.

@bors r+

[bors]

📌 Commit 8502c6c has been approved by jonathandturner

[bors]

💡 This pull request was already approved, no need to approve it again.

• There's another pull request that is currently being tested, blocking this pull request: Changed error message for enum variants #35260

[bors]

📌 Commit 8502c6c has been approved by jonathandturner

[bors]

⌛ Testing commit 8502c6c with merge 802d081...

[bors]

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: jonathandturner
Pushing 802d081 to master...