Make the Iterator::enumerate doc example more clear
#33085
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ rollup thanks, I agree! |
|
📌 Commit 3210942 has been approved by |
|
☔ The latest upstream changes (presumably #33079) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
The example uses integers for the value being iterated over, but the indices added by `enumerate` are also integers, so I always end up double taking and thinking harder than I should when parsing the documentation. I also always forget which order the index and value are in the tuple so I frequently hit this stumbling block. This commit changes the documentation to iterate over characters so that it is immediately obvious which part of the tuple is the index and which is the value.
fitzgen
force-pushed
the
make-enumerate-example-more-clear
branch
from
3210942 to
e078667
Compare
|
Rebased! |
|
@bors: r+ rollup |
|
📌 Commit e078667 has been approved by |
|
⌛ Testing commit e078667 with merge 1e7424b... |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Sat, Apr 23, 2016 at 9:11 PM, bors [email protected] wrote:
|
…teveklabnik Make the `Iterator::enumerate` doc example more clear The example uses integers for the value being iterated over, but the indices added by `enumerate` are also integers, so I always end up double taking and thinking harder than I should when parsing the documentation. I also always forget which order the index and value are in the tuple so I frequently hit this stumbling block. This commit changes the documentation to iterate over characters so that it is immediately obvious which part of the tuple is the index and which is the value.
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors: retry On Sun, Apr 24, 2016 at 3:25 AM, bors [email protected] wrote:
|
…teveklabnik Make the `Iterator::enumerate` doc example more clear The example uses integers for the value being iterated over, but the indices added by `enumerate` are also integers, so I always end up double taking and thinking harder than I should when parsing the documentation. I also always forget which order the index and value are in the tuple so I frequently hit this stumbling block. This commit changes the documentation to iterate over characters so that it is immediately obvious which part of the tuple is the index and which is the value.
The example uses integers for the value being iterated over, but the indices
added by
enumerateare also integers, so I always end up double taking andthinking harder than I should when parsing the documentation. I also always
forget which order the index and value are in the tuple so I frequently hit this
stumbling block. This commit changes the documentation to iterate over
characters so that it is immediately obvious which part of the tuple is the
index and which is the value.