Fix floating point fast-math intrinsics #32362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| extern "C" void LLVMRustSetHasUnsafeAlgebra(LLVMValueRef Instr) { | ||
| unwrap<Instruction>(Instr)->setHasUnsafeAlgebra(true); | ||
| extern "C" void LLVMRustSetHasUnsafeAlgebra(LLVMValueRef V) { | ||
| if(auto O = dyn_cast<Instruction>(unwrap<Value>(V))) O->setHasUnsafeAlgebra(true); |
There was a problem hiding this comment.
Can you put the body on a second line, and call the variable I instead of O? (because it's not an operator, sadly)
|
r? @eddyb |
|
@bors r+ p=1 This is blocking nightlies. |
|
📌 Commit ba89b25 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 19, 2016
Fix floating point fast-math intrinsics The implementation did not handle the case where both operands were constants, which caused an llvm assertion: ``` rustc: //buildslave//rust-buildbot//slave//nightly-dist-rustc-musl-linux//build//src//llvm//include/llvm/Support/Casting.h:237: typename llvm::cast_retty<X, Y*>::ret_type llvm::cast(Y*) [with X = llvm::Instruction; Y = llvm::Value; typename llvm::cast_retty<X, Y*>::ret_type = llvm::Instruction*]: Assertion `isa<X>(Val) && "cast<Ty>() argument of incompatible type!"' failed. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation did not handle the case where both operands were constants, which caused an llvm assertion: