-
Notifications
You must be signed in to change notification settings - Fork 13.3k
libsyntax: note that let a = (let b = something)
is invalid
#30765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7229ca9
libsyntax: note that `let a = (let b = something)` is invalid
dsprenkels a74585b
libsyntax: move check for keyword Let to a more logical spot
dsprenkels 8c74957
Update qquote.rs test case and make unexpected `let` error fatal
dsprenkels 740f2f3
do not additionally note about unexpected identifier after unexpected…
dsprenkels File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message needs some work: why single
let
out here? Rather than other keywords, it seems oddly specific. You probably mean that "alet
statement is not an expression", not thatlet
it self is not. It is not clear what "this way" means.Maybe better, something like:
expected expression, found statement; variable declaration using
letis a statement
. Perhaps the bit after the semicolon should be a note.Note that neither then before or after message fit the
let let x = ...
case, where we expect an identifier, not a keyword, so the original error is better, and the new one (either as well as or instead of) is wrong.