-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Prettify MIR graphviz output #30469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify MIR graphviz output #30469
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit d34417e has been approved by |
cc @tsion |
I have a PR that makes larger changes to the graphviz output, but I see no reason not to merge this now. Most of my changes are for the textual parts (especially constants). I don't have the I'll try to get my PR ready ASAP. |
One will look at graphviz often when working with MIR, so may as well make the tables a bit more pretty :)
d34417e
to
03903cb
Compare
Fixed the build failure, re-r+? @tsion sounds like our patches are pretty unrelated then? Either way, I’m completely fine rebasing onto you or you rebasing onto/merging me. |
@nagisa I'll rebase onto yours. That'll be much simpler. |
@bors: r+ |
📌 Commit 03903cb has been approved by |
⌛ Testing commit 03903cb with merge 48075cc... |
💔 Test failed - auto-win-gnu-32-opt |
@bors: retry On Sun, Dec 20, 2015 at 2:57 AM, bors [email protected] wrote:
|
One will look at graphviz often when working with MIR, so may as well make the tables a bit more pretty :) 
One will look at graphviz often when working with MIR, so may as well make the tables a bit more
pretty :)