Beautify ISAAC's mixing arithmetic #30455
Conversation
Call me verbose, but the existing logic was hideously formatted. The result still fits in a small terminal. No functional change.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| h=h^(a>>9); c=c+h; a=a+b; | ||
| a = a ^ (b << 11); | ||
| d = d + a; | ||
| b = b + c; |
There was a problem hiding this comment.
Why aren't all of these a ^= b << 11;, d += a;, b += c; etc.?
There was a problem hiding this comment.
I initially tried that, but apparently arithmetic assignment operators aren't defined for Wrapping types like these. I imagine they will be eventually - I can't imagine why that wouldn't be simple.
There was a problem hiding this comment.
Oh, I didn't realize those were Wrapping. I guess that's a bug, because we have the traits now.
Call me verbose, but the existing logic was hideously formatted. The result still fits in a small terminal. No functional change.
Call me verbose, but the existing logic was hideously formatted. The
result still fits in a small terminal. No functional change.