librustdoc: improve testnames for doctests #29600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| .next() | ||
| .or_else(|| typename_if_impl(&item)); | ||
|
|
||
| let pushed = name.map(|name| self.names.push(name)).is_some(); |
There was a problem hiding this comment.
This is a little bit hard to follow, so perhaps this could use explicit control flow + if let Some(...) = ... to match what's going on here? Currently it's somewhat non-idiomatic to call .iter() on an option or rely on functions like map for side effects.
There was a problem hiding this comment.
Heh, it got a bit out of hand, will do.
Ryman
force-pushed
the
rustdoc_better_testnames
branch
from
57a0430 to
26e99fc
Compare
|
@alexcrichton Adjusted from feedback |
|
|
||
| fn typename_if_impl(item: &clean::Item) -> Option<String> { | ||
| if let clean::ItemEnum::ImplItem(ref impl_) = item.inner { | ||
| let path = <clean::Type as ToString>::to_string(&impl_.for_); |
There was a problem hiding this comment.
Ah yeah it's fine to use .to_string() here, I was just getting confused :(
There was a problem hiding this comment.
Just pushed adding.to_string() again :)
Ryman
force-pushed
the
rustdoc_better_testnames
branch
from
26e99fc to
4202615
Compare
bors
added a commit
that referenced
this pull request
Nov 6, 2015
Old doctest names ```bash test sync::atomic::load_0 ... ok test sync::atomic::load_0 ... ok test sync::atomic::load_0 ... ok test sync::atomic::load_0 ... ok ``` New doctest names ```bash test sync::atomic::AtomicBool::load_0 ... ok test sync::atomic::AtomicIsize::load_0 ... ok test sync::atomic::AtomicPtr<T>::load_0 ... ok test sync::atomic::AtomicUsize::load_0 ... ok ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old doctest names
New doctest names