trpl: Clarify closure terminology #28856
Conversation
This is to address issue rust-lang#28803
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| close over an environment. Rust has a really great implementation of them, as | ||
| we’ll see. | ||
| Sometimes it is useful to wrap up a function and free variables for better | ||
| clarity and reuse. The _free variables_ that can be used come from the |
There was a problem hiding this comment.
I would put the hightlight on the first usage rather than the second, I think, but I can't quite say why
There was a problem hiding this comment.
Totally reasonable, probably better to call out the terminology on the first use.
|
Thanks @chills42 ! This is an improvement for sure, just have some nits :) |
|
@steveklabnik I think this is all good to go now. |
|
@bors: r+ rollup |
|
📌 Commit 7895ec2 has been approved by |
|
Thank you! |
This is to address issue rust-lang#28803 by improving some of the references to closures, to explain what they are more clearly, while hopefully still being concise. r? @steveklabnik
This is to address issue rust-lang#28803 by improving some of the references to closures, to explain what they are more clearly, while hopefully still being concise. r? @steveklabnik
This is to address issue #28803 by improving some of the references to closures, to explain what they are more clearly, while hopefully still being concise.
r? @steveklabnik