Skip to content

run-make: search libstdc++ in /usr/local/lib too #28569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Sep 21, 2015

extend the search path of libraries to /usr/local/lib in run-make
testsuite. It should permit to find libstdc++.so on usual directory.

r? @alexcrichton

@semarie
Copy link
Contributor Author

semarie commented Sep 21, 2015

I don't redo all the stuff in configure:

  • ensuring the stdc++ library name (libstdc++ or libestdc++)
  • retreiving the library path from the library name

If you think it should be done in testsuite too, I will add it.

@alexcrichton
Copy link
Member

Which ones of the run-make tests need libstdc++? I would hope that it's only the compiler which needs that...

@semarie
Copy link
Contributor Author

semarie commented Sep 21, 2015

the failing tests without this patch are:

  • run-make/execution-engine
  • run-make/issue-19371

@alexcrichton
Copy link
Member

Can you add a comment indicating what this -L flag is needed for? (as well as the tests which fail without it)

extend the search path of libraries to /usr/local/lib in `run-make`
testsuite. It should permit to find libstdc++.so on usual directory.
@semarie
Copy link
Contributor Author

semarie commented Sep 23, 2015

PR updated

@alexcrichton
Copy link
Member

@bors: r+ 8474af0

@bors
Copy link
Collaborator

bors commented Sep 23, 2015

⌛ Testing commit 8474af0 with merge afae2ff...

bors added a commit that referenced this pull request Sep 23, 2015
extend the search path of libraries to /usr/local/lib in `run-make`
testsuite. It should permit to find libstdc++.so on usual directory.

r? @alexcrichton
@bors bors merged commit 8474af0 into rust-lang:master Sep 23, 2015
@semarie semarie deleted the stdcpp-tests branch November 11, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants