Skip to content

std: Remove msvc/valgrind headers #27339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Conversation

alexcrichton
Copy link
Member

These aren't really used for anything any more, so there doesn't seem to be much
reason to leave them around in the rt directory. There was some limiting of
threads spawned or tests when run under valgrind, but very little is run under
valgrind nowadays so there's also no real use keeping these around.

@rust-highfive
Copy link
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned pcwalton Jul 27, 2015
These aren't really used for anything any more, so there doesn't seem to be much
reason to leave them around in the `rt` directory. There was some limiting of
threads spawned or tests when run under valgrind, but very little is run under
valgrind nowadays so there's also no real use keeping these around.
@brson
Copy link
Contributor

brson commented Jul 27, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 27, 2015

📌 Commit cf1ff56 has been approved by brson

@bors
Copy link
Collaborator

bors commented Jul 28, 2015

⌛ Testing commit cf1ff56 with merge 51e3a17...

@bors
Copy link
Collaborator

bors commented Jul 28, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member Author

@bors: retry

On Tue, Jul 28, 2015 at 8:15 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/5873


Reply to this email directly or view it on GitHub
#27339 (comment).

@bors
Copy link
Collaborator

bors commented Jul 29, 2015

⌛ Testing commit cf1ff56 with merge 4b4119d...

bors added a commit that referenced this pull request Jul 29, 2015
These aren't really used for anything any more, so there doesn't seem to be much
reason to leave them around in the `rt` directory. There was some limiting of
threads spawned or tests when run under valgrind, but very little is run under
valgrind nowadays so there's also no real use keeping these around.
@bors bors merged commit cf1ff56 into rust-lang:master Jul 29, 2015
@alexcrichton alexcrichton deleted the remove-old-rt branch August 17, 2015 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants