Replace many uses of mem::transmute with more specific functions
#27252
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
I think this might be getting a little too ambitious with the additions to the public APIs of these types. The |
|
@alexcrichton |
|
Could this be split into separate PRs? Landing removal of |
|
@alexcrichton |
| @@ -389,6 +389,7 @@ impl<K, V> Node<K, V> { | |||
|
|
|||
| #[inline] | |||
| pub fn as_slices_internal_mut<'b>(&'b mut self) -> MutNodeSlice<'b, K, V> { | |||
| // TODO: Bad: This relies on structure layout! | |||
There was a problem hiding this comment.
I think this won't pass make tidy (due to the TODO). Could you remove this and perhaps it can be just handled later?
|
☔ The latest upstream changes (presumably #27012) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Needs a rebase and travis is mad. |
tbu-
force-pushed
the
pr_less_transmutes
branch
from
d2ec989 to
a6bd9fc
Compare
The replacements are functions that usually use a single `mem::transmute` in their body and restrict input and output via more concrete types than `T` and `U`. Worth noting are the `transmute` functions for slices and the `from_utf8*` family for mutable slices. Additionally, `mem::transmute` was often used for casting raw pointers, when you can already cast raw pointers just fine with `as`.
tbu-
force-pushed
the
pr_less_transmutes
branch
from
c8dbd85 to
2ec2668
Compare
|
@alexcrichton |
The replacements are functions that usually use a single `mem::transmute` in their body and restrict input and output via more concrete types than `T` and `U`. Worth noting are the `transmute` functions for slices and the `from_utf8*` family for mutable slices. Additionally, `mem::transmute` was often used for casting raw pointers, when you can already cast raw pointers just fine with `as`. This builds upon #27233.
The replacements are functions that usually use a single
mem::transmutein their body and restrict input and output via more concrete types thanTandU. Worth noting are thetransmutefunctions for slices and thefrom_utf8*family for mutable slices. Additionally,mem::transmutewas often used for casting raw pointers, when you can already cast raw pointers just fine withas.This builds upon #27233.