Skip to content

Move wrapper types blog post into trpl #26960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2015

Conversation

Manishearth
Copy link
Member

@steveklabnik had suggested I do this.

This needs much review -- I tried reducing the informal tone but there's room for improvement.

r? @steveklabnik

// Alternate title: "Choosing your Guarantees"

A recurring theme in Rust programming is that Rust gives one control over the costs and guarantees
of their program.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A recurring theme in Rust programming is that Rust gives one control over the costs and guarantees
of their program.

Maybe instead: "One important feature of Rust as language ist that it lets one control the costs and guarantees
of their program."

(By the way, is the rest of the book written in the "you/your" or "one/their" style?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killercup 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of a program 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(it's usually in you/your, because we try to stick to 'we' generally)

## `Box<T>`

[`Box<T>`][box] is pointer which is &ldquo;owned&rdquo;, or a &ldquo;box&rdquo;. While it can hand
out borrowed references to the contained data, it is the only owner of the data. In particular, when
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"borrowed reference" isn't a thing. Consider dropping "borrowed".

@steveklabnik
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

📌 Commit 7f4caf6 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

⌛ Testing commit 7f4caf6 with merge 0ade894...

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

💔 Test failed - auto-mac-64-nopt-t

@Manishearth
Copy link
Member Author

@bors: r=steveklabnik

@bors
Copy link
Collaborator

bors commented Jul 24, 2015

📌 Commit beca53a has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 24, 2015
…labnik

@steveklabnik had suggested I do this.

This needs much review -- I tried reducing the informal tone but there's room for improvement.


r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Jul 25, 2015

⌛ Testing commit beca53a with merge 0f9f13e...

stay the same between the time you first read it and when you intend to use it.

```rust
let x = Cell::new(1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing imports here

@bors
Copy link
Collaborator

bors commented Jul 25, 2015

💔 Test failed - auto-mac-64-opt

@Manishearth
Copy link
Member Author

@bors: r=steveklabnik

fixed docs

@bors
Copy link
Collaborator

bors commented Jul 25, 2015

📌 Commit 8484aca has been approved by steveklabnik

bors added a commit that referenced this pull request Jul 25, 2015
@steveklabnik had suggested I do this.

This needs much review -- I tried reducing the informal tone but there's room for improvement.


r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Jul 25, 2015

⌛ Testing commit 8484aca with merge f0b7ede...

@bors bors merged commit 8484aca into rust-lang:master Jul 25, 2015
@Manishearth Manishearth deleted the wrapper-types branch September 3, 2015 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants