-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Move wrapper types blog post into trpl #26960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// Alternate title: "Choosing your Guarantees" | ||
|
||
A recurring theme in Rust programming is that Rust gives one control over the costs and guarantees | ||
of their program. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A recurring theme in Rust programming is that Rust gives one control over the costs and guarantees
of their program.
Maybe instead: "One important feature of Rust as language ist that it lets one control the costs and guarantees
of their program."
(By the way, is the rest of the book written in the "you/your" or "one/their" style?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of a program 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(it's usually in you/your, because we try to stick to 'we' generally)
## `Box<T>` | ||
|
||
[`Box<T>`][box] is pointer which is “owned”, or a “box”. While it can hand | ||
out borrowed references to the contained data, it is the only owner of the data. In particular, when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"borrowed reference" isn't a thing. Consider dropping "borrowed".
95388c3
to
7f4caf6
Compare
@bors: r+ |
📌 Commit 7f4caf6 has been approved by |
⌛ Testing commit 7f4caf6 with merge 0ade894... |
💔 Test failed - auto-mac-64-nopt-t |
7f4caf6
to
beca53a
Compare
@bors: r=steveklabnik |
📌 Commit beca53a has been approved by |
…labnik @steveklabnik had suggested I do this. This needs much review -- I tried reducing the informal tone but there's room for improvement. r? @steveklabnik
⌛ Testing commit beca53a with merge 0f9f13e... |
stay the same between the time you first read it and when you intend to use it. | ||
|
||
```rust | ||
let x = Cell::new(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing imports here
💔 Test failed - auto-mac-64-opt |
beca53a
to
8484aca
Compare
@bors: r=steveklabnik fixed docs |
📌 Commit 8484aca has been approved by |
@steveklabnik had suggested I do this. This needs much review -- I tried reducing the informal tone but there's room for improvement. r? @steveklabnik
@steveklabnik had suggested I do this.
This needs much review -- I tried reducing the informal tone but there's room for improvement.
r? @steveklabnik