Skip to content

fix documentation in libserialize #25904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2015
Merged

fix documentation in libserialize #25904

merged 1 commit into from
May 30, 2015

Conversation

benaryorg
Copy link
Contributor

perhaps the smallest and least useful fix in the whole history of rust

I will not blame you if you do not want to merge it

the object was serialized with an 'i' but the comment stated the print command
would output 'j'
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 30, 2015

📌 Commit 2029799 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented May 30, 2015

⌛ Testing commit 2029799 with merge ee1ba33...

bors added a commit that referenced this pull request May 30, 2015
perhaps the smallest and least useful fix in the whole history of rust

I will not blame you if you do not want to merge it
@steveklabnik
Copy link
Member

Thank you! No patch is too small, and all patches have meaning. Please keep submitting them, regardless of size. You've helped make Rust better, and that's what matters.

@benaryorg
Copy link
Contributor Author

I have to thank you, for both, Rust and this inspiring comment!

@bors bors merged commit 2029799 into rust-lang:master May 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants