test: Join child threads on windows in tests #25824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows tests can often deadlock if a child thread continues after the main thread and then panics, and a `println!` executed in a child thread after the main thread has exited is at risk of panicking.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 279ec9b has been approved by |
|
@bors p=1 |
|
⌛ Testing commit 279ec9b with merge dc4818c... |
|
💔 Test failed - auto-win-gnu-32-opt |
|
@bors: retry On Wed, May 27, 2015 at 3:05 PM, bors [email protected] wrote:
|
bors
added a commit
that referenced
this pull request
May 28, 2015
…r=nikomatsakis Windows tests can often deadlock if a child thread continues after the main thread and then panics, and a `println!` executed in a child thread after the main thread has exited is at risk of panicking.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
May 5, 2017
Windows historically has problems with threads panicking and the main thread exiting at the same time, typically causing deadlocks. In the past (rust-lang#25824) we've joined on threads but this just prevents running the test for now to avoid tampering with the example.
bors
added a commit
that referenced
this pull request
May 5, 2017
std: Prevent deadlocks in doctests on Windows Windows historically has problems with threads panicking and the main thread exiting at the same time, typically causing deadlocks. In the past (#25824) we've joined on threads but this just prevents running the test for now to avoid tampering with the example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows tests can often deadlock if a child thread continues after the main
thread and then panics, and a
println!executed in a child thread after themain thread has exited is at risk of panicking.