-
Notifications
You must be signed in to change notification settings - Fork 13.3k
trpl: fix some broken internal links #25410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
The same link is broken in the next chapter (Enums) too. Should I add that to this PR, or is it too late? |
Yeah adding it to this PR is fine, feel free to just ping me once it's in! |
@alexcrichton pushed. |
@alexcrichton actually maybe tell bors to hold off on this and I'll turn it into a more general "fix a bunch of broken TRPL links" PR. |
@bors: r- Ok! |
@durka now that you have this extra commit, i'm assuming this is good to go |
@bors: r+ rollup |
📌 Commit c147ac4 has been approved by |
Should be! I ran out of time going through the book, but I'll see if I
|
No description provided.