Skip to content

trpl: fix some broken internal links #25410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2015
Merged

trpl: fix some broken internal links #25410

merged 3 commits into from
May 15, 2015

Conversation

durka
Copy link
Contributor

@durka durka commented May 14, 2015

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

@bors: r+ dc6eb78 rollup

Thanks!

@durka
Copy link
Contributor Author

durka commented May 14, 2015

The same link is broken in the next chapter (Enums) too. Should I add that to this PR, or is it too late?

@alexcrichton
Copy link
Member

Yeah adding it to this PR is fine, feel free to just ping me once it's in!

@durka
Copy link
Contributor Author

durka commented May 14, 2015

@alexcrichton pushed.

@durka
Copy link
Contributor Author

durka commented May 14, 2015

@alexcrichton actually maybe tell bors to hold off on this and I'll turn it into a more general "fix a bunch of broken TRPL links" PR.

@alexcrichton
Copy link
Member

@bors: r+ 66c0fe0

@alexcrichton
Copy link
Member

@bors: r-

Ok!

@durka durka changed the title trpl: fix link from Structs to Traits trpl: fix some broken internal links May 14, 2015
@steveklabnik
Copy link
Member

@durka now that you have this extra commit, i'm assuming this is good to go

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented May 15, 2015

📌 Commit c147ac4 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 15, 2015
bors added a commit that referenced this pull request May 15, 2015
@durka
Copy link
Contributor Author

durka commented May 15, 2015

Should be! I ran out of time going through the book, but I'll see if I
catch any more when I get back to Rust learning.
On May 14, 2015 8:30 PM, "Steve Klabnik" [email protected] wrote:

@durka https://github.com/durka now that you have this extra commit,
i'm assuming this is good to go


Reply to this email directly or view it on GitHub
#25410 (comment).

@bors bors merged commit c147ac4 into rust-lang:master May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants