librustc_trans: Handle DST structs in trans::_match. #25060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
Does this handle trait objects? |
|
@huonw Yes, it should. Let me update the test case. |
luqmana
force-pushed
the
matching-dst-struct
branch
2 times, most recently
from
f87a986 to
6a46b86
Compare
| let (arg_count, struct_val) = if type_is_sized(bcx.tcx(), left_ty) { | ||
| (arg_count, val) | ||
| } else { | ||
| (arg_count - 1, Load(bcx, expr::get_dataptr(bcx, val))) |
There was a problem hiding this comment.
Could you add a comment about the - 1?
|
r=me with an explanatory comment |
luqmana
force-pushed
the
matching-dst-struct
branch
from
6a46b86 to
715605f
Compare
|
@bors r=huonw |
|
📌 Commit 715605f has been approved by |
bors
added a commit
that referenced
this pull request
May 3, 2015
|
Great job @luqmana 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23261.
cc @blaenk