Skip to content

Fix parallel make check #24537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions mk/tests.mk
Original file line number Diff line number Diff line change
Expand Up @@ -753,20 +753,22 @@ PRETTY_DEPS_pretty-rpass-full = $(RPASS_FULL_TESTS)
PRETTY_DEPS_pretty-rfail = $(RFAIL_TESTS)
PRETTY_DEPS_pretty-bench = $(BENCH_TESTS)
PRETTY_DEPS_pretty-pretty = $(PRETTY_TESTS)
# The stage- and host-specific dependencies are for e.g. macro_crate_test which pulls in
# external crates.
PRETTY_DEPS$(1)_H_$(3)_pretty-rpass =
PRETTY_DEPS$(1)_H_$(3)_pretty-rpass-full = $$(HLIB$(1)_H_$(3))/stamp.syntax $$(HLIB$(1)_H_$(3))/stamp.rustc
PRETTY_DEPS$(1)_H_$(3)_pretty-rfail =
PRETTY_DEPS$(1)_H_$(3)_pretty-bench =
PRETTY_DEPS$(1)_H_$(3)_pretty-pretty =
PRETTY_DIRNAME_pretty-rpass = run-pass
PRETTY_DIRNAME_pretty-rpass-valgrind = run-pass-valgrind
PRETTY_DIRNAME_pretty-rpass-full = run-pass-fulldeps
PRETTY_DIRNAME_pretty-rfail = run-fail
PRETTY_DIRNAME_pretty-bench = bench
PRETTY_DIRNAME_pretty-pretty = pretty

define DEF_PRETTY_FULLDEPS
PRETTY_DEPS$(1)_T_$(2)_H_$(3)_pretty-rpass-full = $$(CSREQ$(1)_T_$(3)_H_$(3))
endef

$(foreach host,$(CFG_HOST), \
$(foreach target,$(CFG_TARGET), \
$(foreach stage,$(STAGES), \
$(eval $(call DEF_PRETTY_FULLDEPS,$(stage),$(target),$(host))))))

define DEF_RUN_PRETTY_TEST

PRETTY_ARGS$(1)-T-$(2)-H-$(3)-$(4) := \
Expand All @@ -780,7 +782,7 @@ check-stage$(1)-T-$(2)-H-$(3)-$(4)-exec: $$(call TEST_OK_FILE,$(1),$(2),$(3),$(4
$$(call TEST_OK_FILE,$(1),$(2),$(3),$(4)): \
$$(TEST_SREQ$(1)_T_$(2)_H_$(3)) \
$$(PRETTY_DEPS_$(4)) \
$$(PRETTY_DEPS$(1)_H_$(3)_$(4))
$$(PRETTY_DEPS$(1)_T_$(2)_H_$(3)_$(4))
@$$(call E, run pretty-rpass [$(2)]: $$<)
$$(Q)touch [email protected]_time
$$(Q)$$(call CFG_RUN_CTEST_$(2),$(1),$$<,$(3)) \
Expand Down
2 changes: 1 addition & 1 deletion src/compiletest/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1452,7 +1452,7 @@ fn make_out_name(config: &Config, testfile: &Path, extension: &str) -> PathBuf {
fn aux_output_dir_name(config: &Config, testfile: &Path) -> PathBuf {
let f = output_base_name(config, testfile);
let mut fname = f.file_name().unwrap().to_os_string();
fname.push("libaux");
fname.push(&format!(".{}.libaux", config.mode));
f.with_file_name(&fname)
}

Expand Down
1 change: 0 additions & 1 deletion src/test/compile-fail-fulldeps/macro-crate-rlib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
// aux-build:rlib_crate_test.rs
// ignore-stage1
// ignore-tidy-linelength
// ignore-android
// ignore-cross-compile gives a different error message

#![feature(plugin)]
Expand Down
3 changes: 2 additions & 1 deletion src/test/run-make/simd-ffi/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ define MK_TARGETS
# on some platforms, but LLVM just prints a warning so that's fine for
# now.
$(1): simd.rs
$$(RUSTC) --target=$(1) --emit=llvm-ir,asm simd.rs -C target-feature='+neon,+sse2'
$$(RUSTC) --target=$(1) --emit=llvm-ir,asm simd.rs \
-C target-feature='+neon,+sse2' -C extra-filename=-$(1)
endef

$(foreach targetxxx,$(TARGETS),$(eval $(call MK_TARGETS,$(targetxxx))))
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/compiler-calls.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// Test that the CompilerCalls interface to the compiler works.

// ignore-android
// ignore-cross-compile

#![feature(rustc_private, path)]
#![feature(core)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/create-dir-all-bare.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-android
// ignore-cross-compile

#![feature(rustc_private)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/issue-15149.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// no-prefer-dynamic
// ignore-android
// ignore-cross-compile

#![feature(rustc_private)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/issue-16992.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// ignore-pretty
// ignore-android
// ignore-cross-compile

#![feature(quote, rustc_private)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/issue-18763-quote-token-tree.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-android
// ignore-cross-compile
// ignore-pretty: does not work well with `--test`

#![feature(quote, rustc_private)]
Expand Down
1 change: 1 addition & 0 deletions src/test/run-pass-fulldeps/qquote.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-cross-compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this one pass previously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the // ignore-test line in that file means that the test is unconditionally skipped. I verified the the test is skipped on one of the Linux buildbot builders. In any case, it needs // ignore-cross-compile because it uses the syntax crate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see. I'm trying to get this test compiling, but it's pretty busted :(

// ignore-pretty
// ignore-test

Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/quote-tokens.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-android
// ignore-cross-compile
// ignore-pretty: does not work well with `--test`

#![feature(quote, rustc_private)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/quote-unused-sp-no-warning.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-android
// ignore-cross-compile
// ignore-pretty: does not work well with `--test`

#![feature(quote, rustc_private)]
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-pass-fulldeps/rename-directory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
// This test can't be a unit test in std,
// because it needs TempDir, which is in extra

// ignore-android
// ignore-cross-compile

#![feature(rustc_private, path_ext)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/default-impl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:rustdoc-default-impl.rs
// ignore-android
// ignore-cross-compile

extern crate rustdoc_default_impl as foo;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/extern-default-method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:rustdoc-extern-default-method.rs
// ignore-android
// ignore-cross-compile

extern crate rustdoc_extern_default_method as ext;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/extern-method.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:rustdoc-extern-method.rs
// ignore-android
// ignore-cross-compile

#![feature(unboxed_closures)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/ffi.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:rustdoc-ffi.rs
// ignore-android
// ignore-cross-compile

extern crate rustdoc_ffi as lib;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/inline-default-methods.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:inline-default-methods.rs
// ignore-android
// ignore-cross-compile

extern crate inline_default_methods;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-13698.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-13698.rs
// ignore-android
// ignore-cross-compile

extern crate issue_13698;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-15318-2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-15318.rs
// ignore-android
// ignore-cross-compile

extern crate issue_15318;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-15318.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-15318.rs
// ignore-android
// ignore-cross-compile

#![feature(no_std)]
#![no_std]
Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-17476.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-17476.rs
// ignore-android
// ignore-cross-compile

extern crate issue_17476;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-19190-3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-19190-3.rs
// ignore-android
// ignore-cross-compile

extern crate issue_19190_3;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-20646.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-20646.rs
// ignore-android
// ignore-cross-compile

#![feature(associated_types)]

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-20727-2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-20727.rs
// ignore-android
// ignore-cross-compile

extern crate issue_20727;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-20727-3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-20727.rs
// ignore-android
// ignore-cross-compile

extern crate issue_20727;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-20727-4.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-20727.rs
// ignore-android
// ignore-cross-compile

extern crate issue_20727;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-20727.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-20727.rs
// ignore-android
// ignore-cross-compile

extern crate issue_20727;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-21092.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-21092.rs
// ignore-android
// ignore-cross-compile

extern crate issue_21092;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-21801.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-21801.rs
// ignore-android
// ignore-cross-compile

extern crate issue_21801;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-22025.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
// except according to those terms.

// aux-build:issue-22025.rs
// ignore-android
// ignore-cross-compile

extern crate issue_22025;

Expand Down
2 changes: 1 addition & 1 deletion src/test/rustdoc/issue-23207.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

// aux-build:issue-23207-1.rs
// aux-build:issue-23207-2.rs
// ignore-android
// ignore-cross-compile

extern crate issue_23207_2;

Expand Down