style nitpicks in rustc and libcollections #22539
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
oli-obk
force-pushed
the
style_nitpicks
branch
from
329e69a to
b789547
Compare
| new_pat | ||
| }) | ||
| } | ||
| Some(const_expr) => const_expr_to_pat(self.tcx, |
There was a problem hiding this comment.
I think that this may wish to retain the outer block because it can be confusing if you expect the indented code below to be the body of the arm but it's in fact a closure.
|
A few small nits here and there, but overall looks great, thanks! (also needs a rebase) |
oli-obk
force-pushed
the
style_nitpicks
branch
2 times, most recently
from
3f66b8c to
5590326
Compare
|
|
||
| ty::BoundSized => { } | ||
| _ => Ok(If(types)), |
There was a problem hiding this comment.
this could allow for future code to be missed, should i create a manual fallback with all possible cases instead?
There was a problem hiding this comment.
Yes keeping an explicit exhaustive match should be done wherever possible .
oli-obk
force-pushed
the
style_nitpicks
branch
from
5590326 to
4e20a81
Compare
|
Sorry for being a little slow, but needs a rebase now. |
oli-obk
force-pushed
the
style_nitpicks
branch
2 times, most recently
from
e4c269c to
a343202
Compare
|
nits addressed and rebased |
oli-obk
force-pushed
the
style_nitpicks
branch
from
a343202 to
1ae4bbf
Compare
|
@bors: r+ 1ae4bbffc668ba25d9e482d7b17a8378c4d71708 rollup |
|
(Needs rebase; removed from rollup) |
oli-obk
force-pushed
the
style_nitpicks
branch
from
1ae4bbf to
4ff50ca
Compare
|
rebased, compilation ok, checks running |
|
checks are also ok |
|
Broke again, rollup just landed. So sorry! Ping me when you get it rebased again. |
oli-obk
force-pushed
the
style_nitpicks
branch
from
4ff50ca to
b67da0f
Compare
|
np, trivial rebase, checks running |
oli-obk
force-pushed
the
style_nitpicks
branch
from
b67da0f to
0bea550
Compare
| @@ -1692,7 +1666,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> { | |||
| self.tcx().sess.bug( | |||
| &format!( | |||
| "asked to assemble constituent types of unexpected type: {}", | |||
| t.repr(self.tcx()))[]); | |||
|
building found two warnings |
|
Okay, you can fix them and just quickly test if they don't fail. Or I can r+ this now, either works. |
|
they are fixed |
|
and make check ran through |
I tried to follow [the style guide][1] as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files. [1]: http://aturon.github.io/style/README.html
I tried to follow the style guide as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files.