-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Update intro.md to fix thread spawning example Closes #22419 #22514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@bors: r+ c2600cf rollup |
Thank you! |
What does the rollup command mean? |
Here's the patch queue: http://buildbot.rust-lang.org/homu/queue/rust basically, it means that this is a low-impact change that's not likely to fail the tests. we mark any PRs that feel right as rollups, and then, when any rollup commit gets built or we kick one off manually, they all get done at once. |
(needs rebase) |
I am not sure to tell what the conflict was because of how the branches are rolled together through a rollup. |
It's 8c34b26, Niko removed
Generally I don't hunt down merge conflicts, I just |
Would I not have to pull the newest master and then merge each of the branches that are in the roll up manually and then see which one has a conflict? And will I be able to fix this conflict since it is in someone else's fork? |
@diamondman the issue is that it doesn't build against master, not other rollup PRs. in general, the rollup is a thing you shouldn't have to worry about. |
No. All the changes from the rollup are on master. The conflict is between your branch and master. |
(To be fair, when I notice that there is a conflict with a not-yet-merged rollup I'll either fix it myself or notify the author, but then I give sufficient details) |
Also, as mentioned before, it's far easier using |
Ah, I understand. Thanks. I will merge on push up
|
Fixed example threaded code in intro doc never printing results. Threads were created with Thread::spawn instead of Thread::scoped.
c2600cf
to
6154c88
Compare
…teveklabnik Fixed example threaded code in intro doc never printing results. Threads were created with Thread::spawn instead of Thread::scoped. Also added correct thread handling like in the first example of the document.
…teveklabnik Fixed example threaded code in intro doc never printing results. Threads were created with Thread::spawn instead of Thread::scoped. Also added correct thread handling like in the first example of the document.
Fixed example threaded code in intro doc never printing results. Threads were created with Thread::spawn instead of Thread::scoped. Also added correct thread handling like in the first example of the document.