Log the current task name in the log! macros. #19444
Conversation
This requires doing an allocation on log! invocations if the current task is named, since there is no non-allocating way to access the name of the current task. Fixes rust-lang#2672
|
Opened #19445 to track the allocation in finding a task's name. |
| @@ -53,14 +53,15 @@ | |||
| #[macro_export] | |||
| macro_rules! log( | |||
| ($lvl:expr, $($arg:tt)+) => ({ | |||
| static LOC: ::log::LogLocation = ::log::LogLocation { | |||
There was a problem hiding this comment.
@alexcrichton had me specifically add in this static code, to reduce code generation.
There was a problem hiding this comment.
Urgh. Initially I tried to keep it, but you can't call ::std::task::name in a static.
|
We may not actually wish to push too hard on this design currently in that #2672 is quite an old issue and @aturon is close to removing tasks entirely. We could support the concept of named threads, but I'd want to make sure we're committing to that API in @reem would you be ok holding off on this to see what the resolution is for |
|
Sure, nothing urgent, just trying to close a triage bug. |
|
FWIW, I do plan to provide naming support for threads, somewhat like what we currently have with tasks. |
|
@reem would you mind actually sending this PR to https://github.com/rust-lang/log instead now? Thanks! |
This requires doing an allocation on log! invocations
if the current task is named, since there is no non-allocating
way to access the name of the current task.
Fixes #2672