json: Improve ergonomics by changing &String to &str in methods and adding Indexing #18544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. |
| fn index<'a>(&'a self, index: &I) -> &'a Json { | ||
| index.index_json(self) | ||
| } | ||
| } |
There was a problem hiding this comment.
With a number of recent changes to traits and such, you should actually be able to implement ops::Index<&'a str, Json> for Json as well as ops::Index<uint, Json> for Json without needing this trait, perhaps that could be tried first?
There was a problem hiding this comment.
Ah, I didn't realise that, thanks. That's great.
Json's find, find_path, and search methods now use &str rather than &String. Json can now be indexed with &str (for Objects) and uint (for Lists). Tests updated to reflect this change. [breaking-change]
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with external
Jsonis pretty unergonomic right now, and has a lot of unnecessary allocations, because everything needs to be converted toString.find,find_path, andsearchnow use&strrather than&String.Indexing can be done with
&stranduint, depending on whether theJsonis anObjector aList.[breaking-change]