Guide: Iterators, Macros and Unsafe wording fixes #18355
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. |
| @@ -4418,7 +4418,7 @@ see why consumers matter. | |||
|
|
|||
| As we've said before, an iterator is something that we can call the `.next()` | |||
| method on repeatedly, and it gives us a sequence of things. Because you need | |||
| to call the method, this means that iterators are **lazy**. This code, for | |||
| to call the method, this means that iterators can be **lazy** and don't need to generate all of the values upfront. This code, for | |||
There was a problem hiding this comment.
iterators are always lazy. but elaborating on what that means is good. can you wrap this line, please?
There was a problem hiding this comment.
Reverted to ‘are’ and rewrapped. :)
This is probably a bad place to ask, so I’ll do it anyway: what’s a good (re)wrapping policy? In general I try to make the least diff noise, but for that it would help if the line breaks were at logical places, so I rewrapped the whole paragraph at sentence breaks. I read an interesting post on this recently, but obviously can’t find the URL at the moment. Still not sure what’s a good approach.
There was a problem hiding this comment.
IT’S A TOPIC NEAR AND DEAR TO MY HEART
|
r=me after the comment is fixed :) |
|
(I fixed the comment and rewrapped as per request.) |
Some more proposed wording fixes for the Guide, this time for the Iterators, Macros and Unsafe chapters. I’m not a native speaker, but this does read better to me, so please do review this critically.