Skip to content

Guide: refresh Testing #18321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2014
Merged

Conversation

chastell
Copy link
Contributor

This refreshes the Cargo commands’ output for the ‘Testing’ chapter to match current reality.

This also drops the ‘Wait a minute, zero tests?’ paragraph, which is no longer relevant when one actually follows the steps in the Guide.

Also, when following the steps in the Guide dilligently, the warning about unused main does not show up again, as src/main.rs is not recompiled when unchanged; these changes address this as well.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

@steveklabnik
Copy link
Member

Awesome. This kind of change is the worst to keep up with. Thanks so much!

@chastell chastell force-pushed the guide_refresh_testing_output branch from 94e950f to eb903b4 Compare October 25, 2014 21:10
@chastell
Copy link
Contributor Author

Argh, you were too fast – I noticed that Cargo not only added the bang to ‘Hello, world!’, but also dropped the semicolon. I updated the relevant commit and rebased, but this removed any ‘r+’ given.

Apologies for the extra work, I didn’t realise the approval process is commit-based. I’ll be more careful in the future. 😅

@chastell
Copy link
Contributor Author

(I only removed the semicolon from the Cargo-generated code and its derivatives, but kept it in the first few hand-written examples that actually mention the semicolon. I think this way it raises fewer questions when the Guide is read top-down.)

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 27, 2014
@bors bors merged commit eb903b4 into rust-lang:master Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants