Skip to content

desugar -> destructure #16852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2014
Merged

desugar -> destructure #16852

merged 1 commit into from
Aug 31, 2014

Conversation

steveklabnik
Copy link
Member

wrong de- word.

@steveklabnik
desugar -> destructure
eb28237 
wrong de- word.
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 31, 2014
@alexcrichton
rollup merge of rust-lang#16852 : steveklabnik/desugar_destructure
56a029f
@bors bors merged commit eb28237 into rust-lang:master Aug 31, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#16852 - ShoyuVanilla:atpit, r=Veykril
d3eeadc 
feat: Implement ATPIT

Resolves rust-lang#16584

Note: This implementation only works for ATPIT, not for TAIT.
The main hinderence that blocks the later is the defining sites of TAIT can be inner blocks like in;
```rust
type X = impl Default;

mod foo {
    fn bar() -> super::X {
        ()
    }
}
```
So, to figure out we are defining it or not, we should recursively probe for nested modules and bodies.

For ATPIT, we can just look into current body because `error[E0401]: can't use 'Self' from outer item` prevent such nested structures;

```rust
trait Foo {
    type Item;
    fn foo() -> Self::Item;
}

struct Bar;

impl Foo for Bar {
    type Item = impl Default;
    fn foo() -> Self::Item {
        fn bar() -> Self::Item {
                    ^^^^^^^^^^
                    |
                    use of `Self` from outer item
                    refer to the type directly here instead
            5
        }
        bar()
    }
}
```

But this implementation does not checks for unification of same ATPIT between different bodies, monomorphization, nor layout for similar reason. (But these can be done with lazyness if we can utilize something like "mutation of interned value" with `db`. I coundn't find such thing but I would appreciate it if such thing exists and you could let me know 😅)
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 13, 2024
@bors
Auto merge of rust-lang#17845 - ShoyuVanilla:tait, r=Veykril
3ef56c2 
feat: Implement TAIT and fix ATPIT a bit

Closes rust-lang#16296 (Commented on the issue)

In rust-lang#16852, I implemented ATPIT, but as I didn't discern ATPIT and other non-assoc TAIT, I guess that it has been working for some TAITs.

As the definining usage of TAIT requires it should be appear in the Def body's type(const blocks' type annotations or functions' signatures), this can be done in simlilar way with ATPIT

And this PR also corrects some defining-usage resolution for ATPIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveklabnik @lilyball @bors