librustc: Implement sugar for the FnMut trait
#14606
Conversation
| &None, | ||
| None, | ||
| None, | ||
| true) |
There was a problem hiding this comment.
This is the point where this function is either taking too many parameters, or this one-line-per-argument is taken too far I feel, this is taking up ~50 lines just for the arguments. I think I just am not a big fan of this style at all...
Not a blocker or anything, just nothing that this is a huge amount of lines with what looks like no gain in readability, but that's likely the fault of the function that takes 11 arguments.
|
The code looks fine to me, modulo style that I don't agree with, but I'm going to hold off on an r+ until an RFC is accepted. |
|
@alexcrichton Look good now that the RFC is accepted via voice vote? |
|
I thought that this was going to be behind a feature gate? r=me with a feature gate + travis fixes |
r? @alexcrichton