Skip to content

Use crate:: prefix for root macro suggestions #141132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use crate:: prefix for root macro suggestions #141132

wants to merge 1 commit into from

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented May 17, 2025

Fixes #141082

I've changed the prefix to crate directly, since it's compatible across all editions.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2025
@fmease fmease assigned fmease and unassigned fee1-dead May 17, 2025
@fmease
Copy link
Member

fmease commented May 17, 2025 •
edited
Loading

Eh, my 'concern' is negligible. Thanks! :)

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 524021c has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@bvanjoi
Copy link
Contributor Author

bvanjoi commented May 17, 2025

I agree with these suggestions and will:

  • Use the revision in issue-99695.rs
  • Create a new issue to propose changing use to pub use

@fmease
Copy link
Member

fmease commented May 17, 2025

Ok :)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 17, 2025
@fmease
Copy link
Member

fmease commented May 17, 2025

Thanks :)
@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 1adfdb4 has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 17, 2025
jieyouxu
jieyouxu reviewed May 17, 2025
View reviewed changes
tests/ui/imports/issue-99695.rs
Copy link
Member

@jieyouxu jieyouxu May 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: while you're modifying this test, can you please rename it to sth more meaningful? We can still keep a backlink to the issue in a doc comment.

Actually nvm, this is in the queue already. I can do that as a follow-up.

fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease
a94cf15 
Use `crate::` prefix for root macro suggestions

Fixes rust-lang#141082

I've changed the prefix to `crate` directly, since it's compatible across all editions.
@fmease fmease mentioned this pull request May 18, 2025
Closed
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#141132 - bvanjoi:issue-141082, r=fmease
9ee320b 
Use `crate::` prefix for root macro suggestions

Fixes rust-lang#141082

I've changed the prefix to `crate` directly, since it's compatible across all editions.
@fmease fmease mentioned this pull request May 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@fmease fmease

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

suggestion/fix (use ::item) is incorrect for editions 2018+
6 participants
@bvanjoi @rustbot @fmease @bors @jieyouxu @fee1-dead