Skip to content

Fast path for register_region_obligation #141129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented May 17, 2025

If a type has no params, infer, placeholder, or non-'static free regions, then we can skip registering outlives obligations since the type has no components which affect lifetime checking in an interesting way.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 17, 2025
@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 17, 2025
@bors
Copy link
Collaborator

bors commented May 17, 2025

⌛ Trying commit 83d8e03 with merge d04c987...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2025
… r=<try>

Fast path for `register_region_obligation`

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 17, 2025

☀️ Try build successful - checks-actions
Build commit: d04c987 (d04c9870ee2261756aec64f0cdefa09dc0581231)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d04c987): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
1.0% [1.0%, 1.0%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.2% [-0.3%, -0.1%] 29
Improvements ✅
(secondary)
-0.2% [-0.5%, -0.0%] 13
All ❌✅ (primary) -0.2% [-0.3%, 1.0%] 30

Max RSS (memory usage)

Results (primary -1.2%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.0% [3.0%, 3.0%] 1
Regressions ❌
(secondary)
2.6% [1.6%, 3.7%] 10
Improvements ✅
(primary)
-1.7% [-2.6%, -1.0%] 10
Improvements ✅
(secondary)
-1.1% [-1.7%, -0.6%] 9
All ❌✅ (primary) -1.2% [-2.6%, 3.0%] 11

Cycles

Results (secondary -0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.0% [-2.7%, -0.4%] 8
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 775.66s -> 776.299s (0.08%)
Artifact size: 365.38 MiB -> 365.29 MiB (-0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 17, 2025
@compiler-errors
Copy link
Member Author

r? @lcnr or @oli-obk

@compiler-errors compiler-errors marked this pull request as ready for review May 17, 2025 19:31
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2025
@compiler-errors
Copy link
Member Author

This is marked as "perf regression" but it only regresses on nalgebra, which has been super bimodal recently afaict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants