Skip to content

bump windows crate for compiler,bootstrap and tools #141127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bump windows crate for compiler,bootstrap and tools #141127

wants to merge 2 commits into from

Conversation

klensy
Copy link
Contributor

@klensy klensy commented May 17, 2025

This dedupes crate versions. For x86_64-pc-windows-msvc stage1 cuts few kb from rustc_driver.dll, nice.

@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 17, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@albertlarsan68
Copy link
Member

r? t-compiler
LGTM for the bootstrap part

@rustbot rustbot assigned estebank and unassigned albertlarsan68 May 17, 2025
@albertlarsan68 albertlarsan68 self-assigned this May 17, 2025
@jieyouxu
Copy link
Member

Compiler side is fine.
@bors r=albertlarsan68,jieyouxu

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 40940e1 has been approved by albertlarsan68,jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
@jieyouxu jieyouxu assigned jieyouxu and unassigned estebank May 17, 2025
fmease added a commit to fmease/rust that referenced this pull request May 18, 2025
@fmease
Rollup merge of rust-lang#141127 - klensy:windows-bump-61, r=albertla…
4c5ddec 
…rsan68,jieyouxu

bump windows crate for compiler,bootstrap and tools

This dedupes crate versions. For `x86_64-pc-windows-msvc` stage1 cuts few kb from `rustc_driver.dll`, nice.
@fmease fmease mentioned this pull request May 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertlarsan68 albertlarsan68 albertlarsan68 approved these changes

Assignees

@jieyouxu jieyouxu

@albertlarsan68 albertlarsan68

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@klensy @rustbot @albertlarsan68 @jieyouxu @bors @estebank