Skip to content

Stabilize feature result_flattening #141072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Rynibami
Copy link

@Rynibami Rynibami commented May 16, 2025

Stabilizes the Result::flatten method

Implementations

Stabilization process

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 16, 2025
@rust-log-analyzer

This comment has been minimized.

@jhpratt
Copy link
Member

jhpratt commented May 16, 2025

Yes, FCP is necessary and will be done on this PR. There's nothing you need to do on that front.

@Rynibami Rynibami force-pushed the stabilize-const-result-flatten branch from 6fd9348 to 4c2d3bc Compare May 16, 2025 10:02
@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented May 16, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@RalfJung RalfJung added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 16, 2025
#[unstable(feature = "result_flattening", issue = "70142")]
#[rustc_const_unstable(feature = "result_flattening", issue = "70142")]
#[stable(feature = "result_flattening", since = "CURRENT_RUSTC_VERSION")]
#[rustc_allow_const_fn_unstable(const_precise_live_drops)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses of this attribute should always be called out in the PR as they require special attention. However, this one should be fine, for the same reason as all the other rustc_allow_const_fn_unstable(const_precise_live_drops): if we change how const_precise_live_drops works, we'll ensure it keeps accepting these cases.

Cc @rust-lang/wg-const-eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants