Skip to content

triagebot: Better message for changes to tests/rustdoc-json #140773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

triagebot: Better message for changes to tests/rustdoc-json #140773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion triagebot.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,7 +1001,15 @@ message = "This PR changes how GCC is built. Consider updating src/bootstrap/dow
message = "This PR changes a file inside `tests/crashes`. If a crash was fixed, please move into the corresponding `ui` subdir and add 'Fixes #<issueNr>' to the PR description to autoclose the issue upon merge."

[mentions."tests/rustdoc-json"]
cc = ["@aDotInTheVoid"]
message = """
These commits modify `test/rustdoc-json`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
These commits modify `test/rustdoc-json`.
These commits modify `tests/rustdoc-json`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, this happened in #140812

rustdoc-json is a **public** (but unstable) interface.

Please ensure that if you've changed the output:
- It's intentional.
- The `FORMAT_VERSION` in `src/librustdoc-json-types` is bumped if necessary.
"""
cc = ["@aDotInTheVoid", "@obi1kenobi"]

[mentions."tests/ui/deriving/deriving-all-codegen.stdout"]
message = "Changes to the code generated for builtin derived traits."
Expand Down
Loading