Skip to content

Add -Zindirect-branch-cs-prefix #140733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add -Zindirect-branch-cs-prefix #140733

wants to merge 1 commit into from

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented May 7, 2025

cc @ojeda

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 7, 2025
@bjorn3
Copy link
Member

bjorn3 commented May 7, 2025

What exactly does Linux need this for?

@Darksonn
Copy link
Contributor Author

Darksonn commented May 7, 2025 •
edited
Loading

I will add more info to the PR description before removing the draft marker, but for now please see #116852 (comment) and the original clang change.

@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

I was looking into this last week and I think this needs a few more things, and should probably go into (or on top of) @azhogin's #135927, since that allows us to test it properly (and I think it does not make much sense without it?).

I sent a draft PR at #140740 -- please feel free to take the commit into your PR @azhogin. (I rebased @azhogin's there, and I added a Co-developed-by because I wasn't sure how to split it).

It additionally contains the assembly test for call and jmp, the docs and the invalid flag test.

@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

I have kept the commit from here just in case and to show the difference/additions.

@ojeda ojeda mentioned this pull request May 7, 2025
Open
56 tasks
@ojeda
Copy link
Contributor

ojeda commented May 7, 2025

@rustbot label F-target_modifiers A-rust-for-linux

@rustbot rustbot added A-rust-for-linux Relevant for the Rust-for-Linux project F-target_modifiers `#![feature(target_modifiers)]` labels May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-rust-for-linux Relevant for the Rust-for-Linux project F-target_modifiers `#![feature(target_modifiers)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Darksonn @bjorn3 @ojeda @rustbot