eagerly compute sub_relations again

[lcnr]

We still only using them for diagnostics with the old solver.

We could use them for cycle detection in generalization and it seems desirable to do so in the future. However, this is unsound with the old trait solver as its cache does not track these sub_relations in any way. We would also need to consider them when canonicalizing as otherwise instantiating the canonical response may fail.

Necessary for type inference guidance due to not-yet defined opaque types, cc rust-lang/trait-system-refactor-initiative#182.

r? @compiler-errors

[lcnr]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 54a32a1 with merge 3c1d077...

[compiler-errors]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 26f4ee0 with merge e184142...

[bors]

☀️ Try build successful - checks-actions
Build commit: e184142 (e1841428183d264d2f48328b3de5c0f25654315a)

[rust-timer]

Finished benchmarking commit (e184142): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 1.7%]	75
Regressions ❌ (secondary)	0.4%	[0.2%, 0.7%]	48
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 1.7%]	75

Max RSS (memory usage)

Results (primary -0.6%, secondary -4.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.4%]	12
Improvements ✅ (secondary)	-4.5%	[-4.5%, -4.5%]	1
All ❌✅ (primary)	-0.6%	[-1.1%, 0.8%]	13

Cycles

Results (primary 0.0%, secondary -1.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	3
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-0.6%	[-0.7%, -0.5%]	3
Improvements ✅ (secondary)	-2.6%	[-2.8%, -2.1%]	4
All ❌✅ (primary)	0.0%	[-0.7%, 0.9%]	6

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 765.701s -> 765.069s (-0.08%)
Artifact size: 365.36 MiB -> 365.11 MiB (-0.07%)

[bors]

☔ The latest upstream changes (presumably #140474) made this pull request unmergeable. Please resolve the merge conflicts.

[lcnr]

see perf run in #140480 (comment)

[lcnr]

comparing these two perf runs, tracking sub_relations in canonical inputs does slightly worsen performance: https://perf.rust-lang.org/compare.html?start=e1841428183d264d2f48328b3de5c0f25654315a&end=9613271ee15ea18ed41f396fc7aaf4c1f760410a&stat=instructions%3Au

[bors]

⌛ Trying commit 8eb514a with merge 8b3ed20...

[bors]

☀️ Try build successful - checks-actions
Build commit: 8b3ed20 (8b3ed207167564e3513248833d6bc40fb83a4b72)

[rust-timer]

Finished benchmarking commit (8b3ed20): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 1.5%]	84
Regressions ❌ (secondary)	0.4%	[0.2%, 0.8%]	51
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.1%, 1.5%]	84

Max RSS (memory usage)

Results (primary -0.1%, secondary -2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[0.6%, 3.2%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.7%, -0.4%]	10
Improvements ✅ (secondary)	-2.3%	[-2.7%, -2.1%]	3
All ❌✅ (primary)	-0.1%	[-1.7%, 3.2%]	13

Cycles

Results (primary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.9%]	25
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.7%, -0.4%]	11
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-0.7%, 1.9%]	36

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 769.964s -> 770.666s (0.09%)
Artifact size: 365.50 MiB -> 365.34 MiB (-0.04%)

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 1bf7f04 with merge a3b1b7c...

[bors]

💔 Test failed - checks-actions

[lcnr]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 53c24cb with merge d2329c5...

[rust-log-analyzer]

The job x86_64-gnu-llvm-19 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#18 exporting to docker image format
#18 sending tarball 20.0s done
#18 DONE 26.8s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-19]
[CI_JOB_NAME=x86_64-gnu-llvm-19]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Listening on address 127.0.0.1:4226
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-19', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'build.print-step-timings', '--enable-verbose-tests', '--set', 'build.metrics', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--set', 'gcc.download-ci-gcc=true', '--enable-new-symbol-mangling']
configure: build.build          := x86_64-unknown-linux-gnu
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-19/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
   2:     0x7f386476cae9 - <std[db91a6d99c7f1cf2]::sys::stdio::unix::Stderr as std[db91a6d99c7f1cf2]::io::Write>::write_fmt
   3:     0x7f3864778e92 - <std[db91a6d99c7f1cf2]::sys::backtrace::BacktraceLock>::print
   4:     0x7f386477d4f1 - std[db91a6d99c7f1cf2]::panicking::default_hook::{closure#0}
   5:     0x7f386477d287 - std[db91a6d99c7f1cf2]::panicking::default_hook
   6:     0x7f3860443da3 - <alloc[2bd2ac7d1b4d7344]::boxed::Box<rustc_driver_impl[6924dacfd6b30e16]::install_ice_hook::{closure#1}> as core[7cbf36d1a8e6186a]::ops::function::Fn<(&dyn for<'a, 'b> core[7cbf36d1a8e6186a]::ops::function::Fn<(&'a std[db91a6d99c7f1cf2]::panic::PanicHookInfo<'b>,), Output = ()> + core[7cbf36d1a8e6186a]::marker::Send + core[7cbf36d1a8e6186a]::marker::Sync, &std[db91a6d99c7f1cf2]::panic::PanicHookInfo)>>::call
   7:     0x7f386477e077 - std[db91a6d99c7f1cf2]::panicking::rust_panic_with_hook
   8:     0x7f386477dcac - std[db91a6d99c7f1cf2]::panicking::begin_panic_handler::{closure#0}
   9:     0x7f38647795f9 - std[db91a6d99c7f1cf2]::sys::backtrace::__rust_end_short_backtrace::<std[db91a6d99c7f1cf2]::panicking::begin_panic_handler::{closure#0}, !>
  10:     0x7f386477d896 - __rustc[ec7fb6ce294bfd5b]::rust_begin_unwind
  11:     0x7f38603d50b0 - core[7cbf36d1a8e6186a]::panicking::panic_fmt
  12:     0x7f38603d508b - core[7cbf36d1a8e6186a]::option::expect_failed
  13:     0x7f386329cd88 - <rustc_infer[d2cdb5cfe5c7cc0f]::infer::InferCtxt>::instantiate_nll_query_response_and_region_obligations::<alloc[2bd2ac7d1b4d7344]::vec::Vec<rustc_middle[c2b98c63db645f01]::traits::query::OutlivesBound>>
  14:     0x7f386338c583 - rustc_trait_selection[c96837a1beeb38bb]::traits::outlives_bounds::implied_outlives_bounds

[rust-log-analyzer]

The job dist-x86_64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
[RUSTC-TIMING] fluent_langneg test:false 0.419
   3:     0x7f36dcbf9052 - std::sys::backtrace::BacktraceLock::print::he8180f7f55f3b842
   4:     0x7f36dcbfce1c - std::panicking::default_hook::{{closure}}::hc1b532ec2262b49b
   5:     0x7f36dcbfcc1f - std::panicking::default_hook::hc9e8cc08aa8a6867
   6:     0x7f36d9e890de - std[875ca2e4757441df]::panicking::update_hook::<alloc[4a17c0b16eaf1993]::boxed::Box<rustc_driver_impl[a5c31e31cf9aa58b]::install_ice_hook::{closure#1}>>::{closure#0}
   7:     0x7f36dcbfd983 - std::panicking::rust_panic_with_hook::ha1cd71477b593eb5
   8:     0x7f36dcbfd63a - std::panicking::begin_panic_handler::{{closure}}::h20531a25291496b6
   9:     0x7f36dcbf9709 - std::sys::backtrace::__rust_end_short_backtrace::h6dfbb58c4ae504f2
  10:     0x7f36dcbfd2cd - __rustc[ec7fb6ce294bfd5b]::rust_begin_unwind
  11:     0x7f36dcc43270 - core::panicking::panic_fmt::h18655c03ee1a104d
  12:     0x7f36dcc4313b - core::option::expect_failed::hc0caae72c7fccacb
  13:     0x7f36dbf37900 - rustc_trait_selection[607c9fdf1ec85bb]::traits::outlives_bounds::implied_outlives_bounds

[bors]

💔 Test failed - checks-actions