Skip to content

Added support for apxf target feature #139534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2025
Merged

Added support for apxf target feature #139534

merged 3 commits into from
May 7, 2025

Conversation

madhav-madhusoodanan
Copy link
Contributor

@madhav-madhusoodanan madhav-madhusoodanan commented Apr 8, 2025 •
edited
Loading

Context

  1. Added the apxf target feature, which is dependent upon the LLVM features egpr, push2pop2, ppx, ndd, ccmp, nf, cf and zu.
  2. Converted dependencies of LLVMFeature from an Option to a SmallVec to support multiple dependencies.

Associated Issue

cc: @sayantn

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 8, 2025
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 970fb61 to 336c5f9 Compare April 8, 2025 15:40
@madhav-madhusoodanan madhav-madhusoodanan marked this pull request as ready for review April 8, 2025 15:41
@madhav-madhusoodanan madhav-madhusoodanan marked this pull request as draft April 8, 2025 15:43
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 336c5f9 to 282deb3 Compare April 8, 2025 16:56
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 282deb3 to d7bc563 Compare April 8, 2025 17:20
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from d7bc563 to b3e9d21 Compare April 8, 2025 17:38
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from b3e9d21 to c0626b5 Compare April 8, 2025 17:48
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from c0626b5 to 994c752 Compare April 8, 2025 17:59
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 994c752 to eaf714b Compare April 8, 2025 18:29
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from eaf714b to 6c4b6dc Compare April 8, 2025 18:55
@madhav-madhusoodanan madhav-madhusoodanan marked this pull request as ready for review April 8, 2025 19:54
@madhav-madhusoodanan
Copy link
Contributor Author

I would be grateful if a perf-run could be initiated for this PR.

I think I do not have sufficient privileges for initiating it.

sayantn
sayantn suggested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@sayantn sayantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do run ./x check tidy before you push, it ensures that CI won't fail right away due to tidy checks

@SparrowLii
Copy link
Member

Sry I'm not familar with llvm so
r? codegen

@rustbot rustbot assigned workingjubilee and unassigned SparrowLii Apr 9, 2025
@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 6c4b6dc to 99b5a86 Compare April 9, 2025 11:16
@madhav-madhusoodanan
Copy link
Contributor Author

Have updated dependencies from a SmallVec<[_, 10]> to a SmallVec<[_, 1]>.

@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from b260411 to 9d85006 Compare April 23, 2025 07:42
@madhav-madhusoodanan
Copy link
Contributor Author

No, leave it off. There are enough instructions that you can't necessarily use an egpr.

Just to clarify, llvm_utils by default wraps the target string into an LLVMFeature, so I'm guessing we wouldn't explicitly need to add inline-asm-use-gpr32 right? (incase a developer needs to use the feature, that is)

@sayantn
Copy link
Contributor

sayantn commented Apr 23, 2025

iiuc, the reason apxf should not imply inline-asm-use-gpr32 is that the new r16-31 registers don't support evex or vex encoded instructions, only rex2 encoding. So they can't be used as regular registers. If inline-asm-use-gpr32 is enabled, llvm might assign a egpr in a reg class, which will generate invalid asm. Target features should not create unsoundess (although they have the potential to do so 😆). There are llvm constraints that we can use to allow users to use gpr32 without activating the i-a-u-g32 tag, so this is not a loss. @chorman0773 is working on a new reg class that will do exactly this, so no need for i-a-u-g32 here

@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 9d85006 to 3ac1f53 Compare April 23, 2025 11:16
@workingjubilee
Copy link
Member

cool, this looks reasonable, have to doublecheck if I need to check about target features with someone first before approving this, I think

@madhav-madhusoodanan
Copy link
Contributor Author

cool, this looks reasonable, have to doublecheck if I need to check about target features with someone first before approving this, I think

Got it 😊

@sayantn sayantn mentioned this pull request May 4, 2025
Open
3 tasks
@bors
Copy link
Collaborator

bors commented May 4, 2025

☔ The latest upstream changes (presumably #140633) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee
Copy link
Member

Ah found the documentation again, and I do not need to consult anyone for this feature. Yay. Rebase? and I'll get it this time.

@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from 3ac1f53 to f59bcee Compare May 6, 2025 02:20
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@madhav-madhusoodanan
Copy link
Contributor Author

Just rebased this branch and I noticed a bunch of changes to Cargo.lock.
Would it be a concern?

@sayantn
Copy link
Contributor

sayantn commented May 6, 2025

Cargo.lock shouldn't have been modified, might just be a mistake from git. You probably have to revert it

@workingjubilee
Copy link
Member

There should not need to be any Cargo.lock changes as part of this PR.

@madhav-madhusoodanan madhav-madhusoodanan force-pushed the apx-target-feature-addition branch from f59bcee to c32dc2d Compare May 6, 2025 18:10
@workingjubilee
Copy link
Member

Thank you! Should be good to go.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 6, 2025

📌 Commit c32dc2d has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 6, 2025
@jhpratt jhpratt mentioned this pull request May 7, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@bors
Auto merge of rust-lang#140726 - jhpratt:rollup-b6oxopx, r=jhpratt
891b852 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#134273 (de-stabilize bench attribute)
 - rust-lang#139534 (Added support for `apxf` target feature)
 - rust-lang#140419 (Move `in_external_macro` to `SyntaxContext`)
 - rust-lang#140483 (Comment on `Rc` abort-guard strategy without naming unrelated fn)
 - rust-lang#140607 (support duplicate entries in the opaque_type_storage)
 - rust-lang#140656 (collect all Fuchsia bindings into the `fuchsia` module)
 - rust-lang#140668 (Implement `VecDeque::truncate_front()`)
 - rust-lang#140709 (rustdoc: remove unportable markdown lint and old parser)
 - rust-lang#140713 (Structurally resolve in `check_ref_cast` in new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4a8dbe0 into rust-lang:master May 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 7, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2025
@rust-timer
Unrolled build for rust-lang#139534
e372e17 
Rollup merge of rust-lang#139534 - madhav-madhusoodanan:apx-target-feature-addition, r=workingjubilee

Added support for `apxf` target feature
@madhav-madhusoodanan
Copy link
Contributor Author

Thank you so much @sayantn @workingjubilee for helping me in this PR 🙏

Learnt quite a bit about adding targets to rustc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayantn sayantn sayantn approved these changes

Assignees

@workingjubilee workingjubilee

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.
10 participants
@madhav-madhusoodanan @rustbot @rust-log-analyzer @SparrowLii @Kobzol @rust-timer @bors @sayantn @chorman0773 @workingjubilee