-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Revert #135914: Remove usages of QueryNormalizer
in the compiler
#136011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #135914: Remove usages of QueryNormalizer
in the compiler
#136011
Conversation
@bors r+ |
@bors rollup=never (perf sensitive 😉) |
Bumping priority above rollup level because it fixes a significant perf regression and because it's been sitting here "in limbo" for four days already @bors p=6 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (122fb29): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.5%, secondary 1.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -6.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.982s -> 776.092s (0.92%) |
Marking as triaged since this is a revert. @rustbot label +perf-regression-triaged |
Reverts #135914.
r? jackh726