Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` #129334

ChayimFriedman2 · 2024-08-20T21:11:40Z

DerefMut is instantly stable, as a trait impl. That means this needs an FCP.

@rustbot label +needs-fcp

rustbot · 2024-08-20T21:11:48Z

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ChayimFriedman2 · 2024-08-20T21:22:28Z

r? libs-api

joboet · 2024-08-21T13:02:54Z

Weird, rustbot seems to be sleeping...
r? libs-api

joboet

The implementation looks good to me, r=me with the nit resolved after the FCP completes.

library/std/src/sys/sync/once/queue.rs

SteveLauC · 2024-09-11T08:57:20Z

Gentle ping on this PR, would love this to be merged soon:)

ChayimFriedman2 · 2024-09-11T10:21:20Z

@SteveLauC This depends on a T-libs-api member starting a FCP.

BurntSushi

New APIs need to land as unstable. And an FCP isn't needed for that. There should also be a tracking issue. And the ACP should be linked.

scottmcm · 2024-09-14T18:53:17Z

Looks like this PR includes DerefMut, which is a trait impl, so that part does need an FCP.

Can you split this into two? One that's just T-libs and only adds unstable methods, and one that's T-libs-api with the stable trait impl. The former can land much more easily than the latter.

ChayimFriedman2 · 2024-09-14T19:00:40Z

@BurntSushi @scottmcm This PR needs FCP for DerefMut and force_mut(), which, as I said in the OP, I decided to make instantly stable because it makes little sense to separate it from DerefMut.

For get_mut(), I already opened a tracking issue: #129333. I can split the PR though.

workingjubilee · 2024-09-14T20:54:58Z

DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.

so you're saying we could land force_mut() on nightly as unstable and then decide to stabilize DerefMut with it?

ChayimFriedman2 · 2024-09-14T21:05:04Z

DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.

so you're saying we could land force_mut() on nightly as unstable and then decide to stabilize DerefMut with it?

That's an option, but that's not what I'm doing in this PR. Instead, I instantly stabilize both.

bors · 2024-09-19T01:14:31Z

☔ The latest upstream changes (presumably #130534) made this pull request unmergeable. Please resolve the merge conflicts.

…force_mut()`

ChayimFriedman2 · 2024-11-16T20:25:56Z

@rustbot ready

I modified this to only add (immediately stable) DerefMut, after the other methods has been added unstably in #130476. This is now ready for FCP.

Although, libs-api may not want to include this until force_mut() stabilizes, or people may resort to this as a workaround (although I expect DerefMut to be used more often anyway, just like Deref vs. force()).

Amanieu · 2025-04-29T15:16:42Z

FCP to stabilize DerefMut directly. force_mut remains unstable tracked under #129333.

@rfcbot merge

rfcbot · 2025-04-29T15:16:44Z

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2025-04-29T15:23:49Z

🔔 This is now entering its final comment period, as per the review above. 🔔

rfcbot · 2025-05-09T15:26:52Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

Amanieu · 2025-05-09T22:34:15Z

@bors r+

bors · 2025-05-09T22:34:18Z

📌 Commit b208706 has been approved by Amanieu

It is now in the queue for this repository.

… r=Amanieu Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` `DerefMut` is instantly stable, as a trait impl. That means this needs an FCP. `@rustbot` label +needs-fcp rust-lang/libs-team#429

Rollup of 10 pull requests Successful merges: - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`) - rust-lang#135015 (Partially stabilize LoongArch target features) - rust-lang#138736 (Sanitizers target modificators) - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious) - rust-lang#140151 (remove intrinsics::drop_in_place) - rust-lang#140660 (remove 'unordered' atomic intrinsics) - rust-lang#140783 (Update documentation of OnceLock::get_or_init.) - rust-lang#140789 (Update hermit-abi to 0.5.1) - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations) - rust-lang#140862 (Enable non-leaf Frame Pointers for Arm64EC Windows) r? `@ghost` `@rustbot` modify labels: rollup

… r=Amanieu Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` `DerefMut` is instantly stable, as a trait impl. That means this needs an FCP. `@rustbot` label +needs-fcp rust-lang/libs-team#429

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`) - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious) - rust-lang#140151 (remove intrinsics::drop_in_place) - rust-lang#140660 (remove 'unordered' atomic intrinsics) - rust-lang#140783 (Update documentation of OnceLock::get_or_init.) - rust-lang#140789 (Update hermit-abi to 0.5.1) - rust-lang#140792 (Use intrinsics for `{f16,f32,f64,f128}::{minimum,maximum}` operations) - rust-lang#140879 (1.87.0 release notes: remove nonsensical `~` operator) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#129334 (Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]`) - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious) - rust-lang#140151 (remove intrinsics::drop_in_place) - rust-lang#140660 (remove 'unordered' atomic intrinsics) - rust-lang#140783 (Update documentation of OnceLock::get_or_init.) - rust-lang#140789 (Update hermit-abi to 0.5.1) - rust-lang#140879 (1.87.0 release notes: remove nonsensical `~` operator) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#129334 - ChayimFriedman2:more-lazy-methods, r=Amanieu Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` `DerefMut` is instantly stable, as a trait impl. That means this needs an FCP. ``@rustbot`` label +needs-fcp rust-lang/libs-team#429

rustbot assigned joboet Aug 20, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, so needs a completed FCP to proceed. labels Aug 20, 2024

ChayimFriedman2 mentioned this pull request Aug 20, 2024

Tracking Issue for lazy_get #129333

Open

5 tasks

rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 21, 2024

rustbot assigned BurntSushi and unassigned joboet Aug 21, 2024

joboet approved these changes Aug 23, 2024

View reviewed changes

library/std/src/sys/sync/once/queue.rs Outdated Show resolved Hide resolved

ChayimFriedman2 force-pushed the more-lazy-methods branch from 2ba55e3 to 37732f5 Compare August 24, 2024 23:04

BurntSushi requested changes Sep 14, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2024

workingjubilee mentioned this pull request Sep 17, 2024

Implement ACP 429: add Lazy{Cell,Lock}::get[_mut] and force_mut #130476

Merged

Add DerefMut for Lazy[Cell/Lock] that delegates to the unstable `…

b208706

…force_mut()`

ChayimFriedman2 force-pushed the more-lazy-methods branch from 37732f5 to b208706 Compare November 16, 2024 20:23

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2024

ChayimFriedman2 requested a review from BurntSushi November 16, 2024 20:27

Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 29, 2025

Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 29, 2025

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 29, 2025

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels May 9, 2025

rustbot mentioned this pull request May 9, 2025

Tracking issue for release notes of #129334: Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] #140853

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2025

Zalathar mentioned this pull request May 10, 2025

Rollup of 10 pull requests #140885

Closed

matthiaskrgr mentioned this pull request May 10, 2025

Rollup of 8 pull requests #140890

Closed

matthiaskrgr mentioned this pull request May 10, 2025

Rollup of 7 pull requests #140895

Merged

bors merged commit c6b9253 into rust-lang:master May 10, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 10, 2025

ChayimFriedman2 deleted the more-lazy-methods branch May 10, 2025 21:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` #129334

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` #129334

ChayimFriedman2 commented Aug 20, 2024 •

edited

Loading

rustbot commented Aug 20, 2024

ChayimFriedman2 commented Aug 20, 2024 •

edited by joboet

Loading

joboet commented Aug 21, 2024

joboet left a comment

SteveLauC commented Sep 11, 2024

ChayimFriedman2 commented Sep 11, 2024

BurntSushi left a comment

scottmcm commented Sep 14, 2024

ChayimFriedman2 commented Sep 14, 2024

workingjubilee commented Sep 14, 2024

ChayimFriedman2 commented Sep 14, 2024

bors commented Sep 19, 2024

ChayimFriedman2 commented Nov 16, 2024

Amanieu commented Apr 29, 2025

rfcbot commented Apr 29, 2025 •

edited by joshtriplett

Loading

rfcbot commented Apr 29, 2025

rfcbot commented May 9, 2025

Amanieu commented May 9, 2025

bors commented May 9, 2025

Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] #129334

Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] #129334

Conversation

ChayimFriedman2 commented Aug 20, 2024 • edited Loading

rustbot commented Aug 20, 2024

ChayimFriedman2 commented Aug 20, 2024 • edited by joboet Loading

joboet commented Aug 21, 2024

joboet left a comment

Choose a reason for hiding this comment

SteveLauC commented Sep 11, 2024

ChayimFriedman2 commented Sep 11, 2024

BurntSushi left a comment

Choose a reason for hiding this comment

scottmcm commented Sep 14, 2024

ChayimFriedman2 commented Sep 14, 2024

workingjubilee commented Sep 14, 2024

ChayimFriedman2 commented Sep 14, 2024

bors commented Sep 19, 2024

ChayimFriedman2 commented Nov 16, 2024

Amanieu commented Apr 29, 2025

rfcbot commented Apr 29, 2025 • edited by joshtriplett Loading

rfcbot commented Apr 29, 2025

rfcbot commented May 9, 2025

Amanieu commented May 9, 2025

bors commented May 9, 2025

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` #129334

Implement (part of) ACP 429: add `DerefMut` to `Lazy[Cell/Lock]` #129334

ChayimFriedman2 commented Aug 20, 2024 •

edited

Loading

ChayimFriedman2 commented Aug 20, 2024 •

edited by joboet

Loading

rfcbot commented Apr 29, 2025 •

edited by joshtriplett

Loading