-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustdoc: tweak highlighting #12649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: tweak highlighting #12649
Conversation
I'm not a fan of bright orange identifiers. Also, could you upload some more code (e.g. the hashmap example from #12648)? The (Also, this needs a rebase.) |
(If you submit the second commit as a separate PR, I'll r+ it.) |
Rebased and made |
Too many light orange…
|
Now brown. |
I know I've already lost my graphic design degree, but perhaps we don't have to color all identifiers? |
@alexcrichton Do you mean all of them? everything in brown here is |
Indeed, I figured most would be black, but take that with a grain of salt (I'm very bad at design) |
cc @brson |
I like this scheme (looks like candy), but @alexcrichton has a point about black idents - if everything has a color it lessens the impact of everything else. Can we see one with black idents? |
Here is HashMap with black idents. |
Updated. r? |
Could you also post a preview of some more source code? I'm curious what this looks like in lots of code other than just a snippet. |
HashMap (source), Macros (source). (BTW if you have FF or Chrome, just navigate to the page you want, right click > inspect (or press F12) then go under Stylesheet editor and paste the CSS). |
[Here is](http://adrientetar.legtux.org/cached/rust-doc/to_str.rs.html) an example. Closes #12648. @alexcrichton, @huonw
Consistent lint group table in book and README The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book. r? `@xFrednet` I noticed that I left review comments about this in rust-lang#10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI. This is just copy and paste of the current README file on `master`. changelog: none
Here is an example.
Closes #12648.
@alexcrichton, @huonw