Skip to content

rustdoc: tweak highlighting #12649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2014
Merged

rustdoc: tweak highlighting #12649

merged 2 commits into from
Mar 4, 2014

Conversation

adrientetar
Copy link
Contributor

Here is an example.

Closes #12648.

@alexcrichton, @huonw

@huonw
Copy link
Member

huonw commented Mar 2, 2014

I'm not a fan of bright orange identifiers. Also, could you upload some more code (e.g. the hashmap example from #12648)? The to_str module doesn't really have much actual code.

(Also, this needs a rebase.)

@huonw
Copy link
Member

huonw commented Mar 2, 2014

(If you submit the second commit as a separate PR, I'll r+ it.)

@adrientetar
Copy link
Contributor Author

Rebased and made idents darker.

@adrientetar
Copy link
Contributor Author

HashMap.

@liigo
Copy link
Contributor

liigo commented Mar 2, 2014

Too many light orange…
2014年3月2日 下午8:24于 "Adrien Tétar" [email protected]写道:

HashMap http://adrientetar.legtux.org/cached/rust-doc/index.html.


Reply to this email directly or view it on GitHubhttps://github.com//pull/12649#issuecomment-36452826
.

@adrientetar
Copy link
Contributor Author

Now brown.

@alexcrichton
Copy link
Member

I know I've already lost my graphic design degree, but perhaps we don't have to color all identifiers?

@adrientetar
Copy link
Contributor Author

@alexcrichton Do you mean all of them? everything in brown here is idents.

@alexcrichton
Copy link
Member

Indeed, I figured most would be black, but take that with a grain of salt (I'm very bad at design)

@adrientetar
Copy link
Contributor Author

cc @brson

@brson
Copy link
Contributor

brson commented Mar 4, 2014

I like this scheme (looks like candy), but @alexcrichton has a point about black idents - if everything has a color it lessens the impact of everything else. Can we see one with black idents?

@adrientetar
Copy link
Contributor Author

Here is HashMap with black idents.
Yea I agree, I will push an update later today.

@adrientetar
Copy link
Contributor Author

Updated. r?

@alexcrichton
Copy link
Member

Could you also post a preview of some more source code? I'm curious what this looks like in lots of code other than just a snippet.

@adrientetar
Copy link
Contributor Author

HashMap (source), Macros (source).

(BTW if you have FF or Chrome, just navigate to the page you want, right click > inspect (or press F12) then go under Stylesheet editor and paste the CSS).

@bors bors closed this Mar 4, 2014
@bors bors merged commit 0106a04 into rust-lang:master Mar 4, 2014
flip1995 pushed a commit to flip1995/rust that referenced this pull request Apr 18, 2024
Consistent lint group table in book and README

The lint table and the restriction group description was improved in rust-lang#10385, but only in the README. Apply the same changes to the book.

r? `@xFrednet`

I noticed that I left review comments about this in rust-lang#10385, but never submitted them. So to this day they are listed as "pending" in the GitHub UI.

This is just copy and paste of the current README file on `master`.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the rustdoc highlighting colour scheme
6 participants