-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Simplify static_assert_size
s.
#124008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify static_assert_size
s.
#124008
Conversation
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
@bors try |
…ze, r=<try> Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`
i don't think the try build will be useful as it only runs x86-64 linux, but now I can't approve it :D |
So should we just mark as a non-rollup, let it attempt the merge, and see if anything fails then? |
☀️ Try build successful - checks-actions |
yeah, that's how we figure out what happens |
…ze, r=Nilstrieb Simplify `static_assert_size`s. We want to run them on all 64-bit platforms. r? `@ghost`
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
The problem here is the size difference of It would be neat to bit-pack this away: rust/library/std/src/sys_common/wtf8.rs Lines 136 to 146 in becebb3
|
We want to run them on all 64-bit platforms.
54f8f52
to
0d97669
Compare
I have updated that assertion accordingly. Let's try again... @bors r=Nilstrieb |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c25473f): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 678.014s -> 676.875s (-0.17%) |
We want to run them on all 64-bit platforms.
r? @ghost