-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix misleading message in struct repr alignment and packed #121900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misleading message in struct repr alignment and packed #121900
Conversation
r? @wesleywiser rustbot has assigned @wesleywiser. Use r? to explicitly pick a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a verb conjugation nit, r=me after!
r? compiler-errors @rustbot author |
54e61d7
to
53dba7f
Compare
@rustbot r=compiler-errors |
@bors r=compiler-errors |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f7cb53e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 643.294s -> 643.541s (0.04%) |
Fixes #121425
By the way, fix the spans for the argument in the second commit.