Fix impl stripped in rustdoc HTML whereas it should not be in case the impl is implemented on a type alias #119997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
(Failure was expected) |
notriddle
reviewed
Jan 19, 2024
…e impl is implemented on a type alias
GuillaumeGomez
force-pushed
the
fix-stripped-impl-on-ty-alias
branch
from
035c51c to
d7ed15e
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
fix-stripped-impl-on-ty-alias
branch
from
d7ed15e to
0933f48
Compare
|
CI passed this time. Not sure what changed in-between but it fixed the issue. @notriddle Ready for review. :) |
|
@bors r+ |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119015.
I talked about it a bit with @petrochenkov. They might change what
EffectiveVisibilitiesreturn for impl items like this one and make them not only reachable but also re-exported, which would fix this case. It could also potentially break other things, so it'll be done whenever they can and then we can check together.Surprisingly, this fix is making rustdoc even closer to rustc in term of errors (the CI currently fails because currently accepted broken codes aren't working anymore with this change). Not sure exactly why though. This is linked to #110631 from what I could find.
So either I'm missing something here, or we consider it's ok and we consider the failing tests as "should fail" and I'll update
rustdoc-uiones.r? @notriddle