-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix unwrap on None #114461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix unwrap on None #114461
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
struct RGB { | ||
g: f64, | ||
b: f64, | ||
} | ||
|
||
fn main() { | ||
let (r, alone_in_path, b): (f32, f32, f32) = (e.clone(), e.clone()); | ||
//~^ ERROR cannot find value `e` in this scope | ||
//~| ERROR cannot find value `e` in this scope | ||
//~| ERROR mismatched types | ||
let _ = RGB { r, g, b }; | ||
//~^ ERROR cannot find value `g` in this scope | ||
//~| ERROR struct `RGB` has no field named `r` | ||
//~| ERROR mismatched types | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
error[E0425]: cannot find value `e` in this scope | ||
--> $DIR/issue-114423.rs:7:51 | ||
| | ||
LL | let (r, alone_in_path, b): (f32, f32, f32) = (e.clone(), e.clone()); | ||
| ^ not found in this scope | ||
|
||
error[E0425]: cannot find value `e` in this scope | ||
--> $DIR/issue-114423.rs:7:62 | ||
| | ||
LL | let (r, alone_in_path, b): (f32, f32, f32) = (e.clone(), e.clone()); | ||
| ^ not found in this scope | ||
|
||
error[E0425]: cannot find value `g` in this scope | ||
--> $DIR/issue-114423.rs:11:22 | ||
| | ||
LL | let _ = RGB { r, g, b }; | ||
| ^ help: a local variable with a similar name exists: `b` | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-114423.rs:7:50 | ||
| | ||
LL | let (r, alone_in_path, b): (f32, f32, f32) = (e.clone(), e.clone()); | ||
| --------------- ^^^^^^^^^^^^^^^^^^^^^^ expected a tuple with 3 elements, found one with 2 elements | ||
| | | ||
| expected due to this | ||
| | ||
= note: expected tuple `(f32, f32, f32)` | ||
found tuple `(f32, f32)` | ||
|
||
error[E0560]: struct `RGB` has no field named `r` | ||
--> $DIR/issue-114423.rs:11:19 | ||
| | ||
LL | let _ = RGB { r, g, b }; | ||
| ^ `RGB` does not have this field | ||
| | ||
= note: all struct fields are already assigned | ||
|
||
error[E0308]: mismatched types | ||
--> $DIR/issue-114423.rs:11:25 | ||
| | ||
LL | let _ = RGB { r, g, b }; | ||
| ^ expected `f64`, found `f32` | ||
| | ||
help: you can convert an `f32` to an `f64` | ||
| | ||
LL | let _ = RGB { r, g, b: b.into() }; | ||
| ++ +++++++ | ||
|
||
error: aborting due to 6 previous errors | ||
|
||
Some errors have detailed explanations: E0308, E0425, E0560. | ||
For more information about an error, try `rustc --explain E0308`. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized the file name. We're moving away from having no context beyond the issue number in test names. Would you mind changing it to something like
issue-114423-ice-regression-in-suggestion.rs
?