Update Clippy #110718

flip1995 · 2023-04-23T11:30:12Z

A few days late, I was on a business trip, sorry.

…_types, r=xFrednet Test all types supported by [`collection_is_never_read`] changelog: none

bump syn to 2.0 changelog: none

… r=Alexendoo Standardize lint formulation Fixes rust-lang#10631 changelog: Standardize a very frequent lint formulation which had variations

…Jarcho Fix UB in `as_ptr_cast_mut` documentation changelog: none Fixes rust-lang#10628 There's no `String::as_mut_ptr` surprisingly, so the example is actually calling `str::as_mut_ptr` on an empty `str`

Fix false positives and false negatives in `octal_escapes`

Clippy Book Chapter Updates Reborn: Lint Passes This PR adds a new chapter to the book: "Lint passes". No major changes apart from some re-phrasing, fixing typos... etc. ## Notes - Requires rust-lang#10595 to be merged before this one (Or else, a link will be broken). - To talk about the whole project, please use the tracking issue for the project rust-lang#10597 (It also contains a timeline, discussions and more information) changelog: Add a new "Lint passes" chapter to the book r? `@flip1995`

Adds the lint passes chapter to the index. Moves additional reading material for beginners to the front page of the development section. Clarify some details in hir::Ty vs ty::Ty.

…, r=llogiq Book: Improve type checking and lint passes chapters - Adds the lint passes chapter to the index. - Moves additional reading material for beginners to the front page of the development section. - Clarify some details in `hir::Ty` vs `ty::Ty`. `@blyxyas` I started reviewing the chapters that were already merged. Great work. I liked the additional reading chapter so much, that I moved it front and center. Other than that I only had some minor corrections to make. Please review. r? `@llogiq` changelog: none

Co-authored-by: Nahua <[email protected]>

…1995 Clippy Book Chapter Updates Reborn: Macro Expansions This PR adds a new chapter to the book: "Macro Expansions". There weren't big changes apart from grammar, re-phrasing and stylistic choices. ## Notes - **Does not require any other chapter** to be merged before this - To talk about the whole project, please use the tracking issue for the project rust-lang#10597 (It also contains a timeline, discussions and more information) changelog: Add a new "Macro Expansions" chapter to the book r? `@flip1995`

Suggest `std::mem::size_of_val` instead of `std::mem::size_of_value` This fixes the incorrect suggestion to use `std::mem::size_of_value`. It should be [`std::mem::size_of_val`](https://doc.rust-lang.org/std/mem/fn.size_of_val.html). changelog: [`manual_slice_size_calculation`]: suggest `std::mem::size_of_val` rather than `std::mem::size_of_value`

…stion, r=Manishearth Add `manual_slice_size_calculation` applicable suggestion Continuation of rust-lang/rust-clippy#10659 (comment). This adds applicable suggestions to the `manual_slice_size_calculation` lint: ``` error: manual slice size calculation --> $DIR/manual_slice_size_calculation.rs:11:13 | LL | let _ = s_i32.len() * size_of::<i32>(); // WARNING | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::mem::size_of_val(s_i32)` | = note: `-D clippy::manual-slice-size-calculation` implied by `-D warnings` ``` changelog: [`manual_slice_size_calculation`]: add machine applicable suggestion

…=flip1995 Fix `#[allow(clippy::enum_variant_names)]` directly on variants changelog: [`enum_variant_names`]: Fix `#[allow]` attributes applied directly to the enum variant Fixes rust-lang#10695

make [`len_zero`] lint not spanning over parenthesis sorry it should be a quick fix but I was caught up by other stuffs last couple weeks 🤦‍♂️ --- fixes: rust-lang#10529 changelog: make [`len_zero`] lint not spanning over parenthesis

clippy: drop unused semver crate Drop unused `semver` crate dependency. changelog: none

…, r=llogiq Bugfix: Ignore `impl Trait`(s) @ `let_underscore_untyped` Fixes rust-lang#10411 changelog:[`let_underscore_untyped`]: Ignore `impl Trait`(s) that caused false positives.

Add `items_after_test_module` lint Resolves task *3* of rust-lang#10506, alongside *1* resolved at rust-lang#10543 in an effort to help standarize a little bit more testing modules. --- changelog:[`items_after_test_module`]: Added the lint.

rustbot · 2023-04-23T11:30:19Z

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

flip1995 · 2023-04-23T11:30:40Z

@bors rollup=iffy (Cargo.lock update)

Manishearth · 2023-04-23T15:45:09Z

clippy/development/lint_passes.html:194: broken link - `clippy/development/define_lints.html`
clippy/print.html:1827: broken link - `clippy/development/define_lints.html`

flip1995 · 2023-04-24T07:48:41Z

We might want to include linkchecker from rustc into our CI.

Manishearth · 2023-04-24T19:16:42Z

@bors r+ p=1

bors · 2023-04-24T19:16:44Z

📌 Commit bb63b59 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2023-04-24T21:26:00Z

⌛ Testing commit bb63b59 with merge f5559e3...

bors · 2023-04-24T23:38:36Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing f5559e3 to master...

rust-timer · 2023-04-25T01:34:57Z

Finished benchmarking commit (f5559e3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-2.0%	[-2.8%, -0.8%]	3
Improvements ✅ (secondary)	-6.0%	[-7.5%, -4.9%]	6
All ❌✅ (primary)	-2.0%	[-2.8%, -0.8%]	3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.4%	[-4.3%, -2.5%]	4
All ❌✅ (primary)	-	-	0

Update Clippy r? `@Manishearth` A few days late, I was on a business trip, sorry.

robertbastian and others added 30 commits April 6, 2023 16:31

fix

67e836d

Suppress the triggering of some lints in derived structures

cd0009e

bump declare_clippy_lint syn to 2.0

4026dde

Add "Lint Passes" chapter

0b1b535

Fix CI

c19c08f

Test all types supported by [collection_is_never_read]

b85deea

Fix UB in as_ptr_cast_mut documentation

8f979af

Auto merge of rust-lang#10627 - schubart:collection_is_never_read_all…

2a774bb

…_types, r=xFrednet Test all types supported by [`collection_is_never_read`] changelog: none

Update ui tests auxiliary to syn 2.0

3813b8e

bless test error

d406f65

Auto merge of rust-lang#10621 - fee1-dead-contrib:bump_syn, r=flip1995

0d06001

bump syn to 2.0 changelog: none

Standardize lint formulation

6409556

Auto merge of rust-lang#10638 - bluthej:standardize-lint-formulation,…

d2f1b2c

… r=Alexendoo Standardize lint formulation Fixes rust-lang#10631 changelog: Standardize a very frequent lint formulation which had variations

Auto merge of rust-lang#10629 - Alexendoo:as-ptr-cast-mut-docs-ub, r=…

d9c2957

…Jarcho Fix UB in `as_ptr_cast_mut` documentation changelog: none Fixes rust-lang#10628 There's no `String::as_mut_ptr` surprisingly, so the example is actually calling `str::as_mut_ptr` on an empty `str`

Talk about symbol information in "Early Lint Pass"

b473267

Merge pull request rust-lang#10603 from robertbastian/octal

b2edd42

Fix false positives and false negatives in `octal_escapes`

Address comments

d639062

Improve type checking and lint passes chapters

fbb69de

Adds the lint passes chapter to the index. Moves additional reading material for beginners to the front page of the development section. Clarify some details in hir::Ty vs ty::Ty.

Make warning about hir_ty_to_ty more visible

b842e99

Add new chapter: "Macro Expansions"

e3a352d

Co-authored-by: Nahua <[email protected]>

Rename std::mem::size_of_value to std::mem::size_of_val

4fb38cf

Suggest applicable expression for manual slice size calculation lint

503fd56

Add run-rustfix marker and test file

b8fee8b

Use clippy_utils::std_or_core in manual slice size calculation lint

a2580db

Ignore manual_slice_size_calculation in code from macro expansions

2f4f798

blyxyas and others added 10 commits April 22, 2023 21:12

Add lint items_after_test_module

0354cee

Compact emmited lint

1ac8dc5

Auto merge of rust-lang#10696 - Alexendoo:allow-enum-variant-names, r…

9824234

…=flip1995 Fix `#[allow(clippy::enum_variant_names)]` directly on variants changelog: [`enum_variant_names`]: Fix `#[allow]` attributes applied directly to the enum variant Fixes rust-lang#10695

Auto merge of rust-lang#10688 - klensy:no-semver, r=flip1995

9a33778

clippy: drop unused semver crate Drop unused `semver` crate dependency. changelog: none

Ignore impl Trait(s)

bdd0545

Auto merge of rust-lang#10701 - blyxyas:fix-fp-let_underscore_untyped…

4195522

…, r=llogiq Bugfix: Ignore `impl Trait`(s) @ `let_underscore_untyped` Fixes rust-lang#10411 changelog:[`let_underscore_untyped`]: Ignore `impl Trait`(s) that caused false positives.

Merge commit 'a3ed905928a03b6e433d0b429190bf3a847128b3' into clippyup

4beb0a4

Update Cargo.lock

fffef0f

rustbot assigned Manishearth Apr 23, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 23, 2023

This comment has been minimized.

Sign in to view

Clippy book: hotfix for broken link

bb63b59

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023

matthiaskrgr mentioned this pull request Apr 24, 2023

run linkcheck in clippy ci rust-lang/rust-clippy#10711

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 24, 2023

bors merged commit f5559e3 into rust-lang:master Apr 24, 2023

rustbot added this to the 1.71.0 milestone Apr 24, 2023

flip1995 pushed a commit to flip1995/rust that referenced this pull request May 5, 2023

Auto merge of rust-lang#110718 - flip1995:clippyup, r=Manishearth

5514d9f

Update Clippy r? `@Manishearth` A few days late, I was on a business trip, sorry.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Clippy #110718

Update Clippy #110718

flip1995 commented Apr 23, 2023

rustbot commented Apr 23, 2023

flip1995 commented Apr 23, 2023

This comment has been minimized.

Manishearth commented Apr 23, 2023

flip1995 commented Apr 24, 2023

Manishearth commented Apr 24, 2023

bors commented Apr 24, 2023

bors commented Apr 24, 2023

bors commented Apr 24, 2023

rust-timer commented Apr 25, 2023

Update Clippy #110718

Update Clippy #110718

Conversation

flip1995 commented Apr 23, 2023

rustbot commented Apr 23, 2023

flip1995 commented Apr 23, 2023

This comment has been minimized.

Manishearth commented Apr 23, 2023

flip1995 commented Apr 24, 2023

Manishearth commented Apr 24, 2023

bors commented Apr 24, 2023

bors commented Apr 24, 2023

bors commented Apr 24, 2023

rust-timer commented Apr 25, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles