Add shootout meteor contest benchmark. #10478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation of the meteor contest implements: - insertion check with bit trick; - pregenetation of every feasible placement of the pieces on the board; - filtering of placement that implies unfeasible board - central symetry breaking
| }).to_owned_vec(); | ||
|
|
||
| // translating to (0, 0) as minimum coordinates. | ||
| for p in res.mut_iter() { |
There was a problem hiding this comment.
Would it be possible to use a different variable name than p? (there are 5 separate things called p in this function.)
There was a problem hiding this comment.
I can change the parameter of the function to piece, and the others to cur_piece. Is it better? Is it sufficient?
In fact, every p is the piece in the pipe of the transformation. In Haskell, it would be done using composition of function without explicit argument.
… iterate Writing iterate(x, f) is more logical as rust iterator pipeline is left to right.
bors
added a commit
that referenced
this pull request
Nov 15, 2013
This implementation of the meteor contest implements: - insertion check with bit trick; - pregenetation of every feasible placement of the pieces on the board; - filtering of placement that implies unfeasible board - central symetry breaking related to #2776
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 20, 2023
`SpanlessEq` improvements fixes rust-lang#9775 Also includes a simplification to `consts::constant`'s interface since I was already touching the code. At the start of `eq_expr` the check: ```rust if !self.inner.allow_side_effects && left.span.ctxt() != right.span.ctxt() { return false; } ``` was removed. This was added in 49e2501 to handle `cfg` macros. This is better handled by the newly added `check_ctxt`. changelog: [various lints]: Don't consider different `cfg!` expansions to be the same unless they are for the same config. changelog: [various lints]: Don't consider the expansion of two different macros to be equal, even when they expand to the same token sequence. changelog: [various lints]: Don't consider two blocks to be equal if they contain disabled code or empty macro expansions, unless those section contain the exact same token sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation of the meteor contest implements:
board;
related to #2776