capitalized std::int::min_value, max_value #10010

[berleon]

No description provided.

[brson]

@berleon You may also enjoy #10077.

[alexcrichton]

It appears that this branch has gone slightly haywire in terms of what github is seeing. Would you mind rebasing your commits on top of master to get rid of all the intermediate ones? This may also just need a rebase in general.

[berleon]

sorry for this mess. i hope it is now ok.

[huonw]

You closed the pull request, was it accidental?

[berleon]

seems still not working. I rebased my fork on upstream. under compare https://github.com/berleon/rust/compare there are exactly the changes shown I want to commit. But why are here still 8 more commits shown as added?
I am sorry for all this complications. More or less my first pull request. Next time I will do better.

[alexcrichton]

I'd recommend taking a look at https://github.com/mozilla/rust/wiki/Note-git-workflow, but it loooks like you've only got one commit here. What you can try doing is something along the lines of:

git fetch mozilla
git checkout -b my-new-branch mozilla/master
git cherry-pick 7c28c91
git push berleon my-new-branch:master -f

That'll create a new clean branch based on mozilla's current master, plant your commit on top, and then force-push onto your master branch (that this pull request is tracking).

[berleon]

thank you alex, this looks much better now and thanks for the link.

[alexcrichton]

Could you amend the commit message to have Closes #10010 in the name? That way github will be smart enough to close the issue when this gets merged.

[berleon]

looks good?

[berleon]

rebased on master. retry? @alexcrichton

[adrientetar]

@berleon Looks like you missed https://github.com/mozilla/rust/blob/master/src/test/run-pass/deriving-primitive.rs#L16

[alexcrichton]

Closing due to inactivity, but feel free to reopen if you have updates!