Skip to content

pub unit struct constructors can't be resolved cross-crate #8233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Aug 2, 2013 · 1 comment
Closed

pub unit struct constructors can't be resolved cross-crate #8233

bblum opened this issue Aug 2, 2013 · 1 comment
Labels
A-metadata Area: Crate metadata A-resolve Area: Name/path resolution done by `rustc_resolve` specifically

Comments

@bblum
Copy link
Contributor

bblum commented Aug 2, 2013

...even though mentioning the type works fine. This doesn't work:

use std::util;

fn main() {
    let _: Option<util::NonCopyable> = Some(util::NonCopyable);
}

but replacing the expression with None works fine.

nominating well-covered
@emberian
Copy link
Member

emberian commented Aug 2, 2013

Dupe of #7634

@emberian emberian closed this as completed Aug 2, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 13, 2022
@bors
new lint: single_char_lifetime_names
a6f80fc 
This pull request adds a lint against single character lifetime names, as they might not divulge enough information about the purpose of the lifetime. This can make code harder to understand. I placed this in `restriction` rather than `pedantic` (as suggested in rust-lang#8233) since most of the Rust ecosystem already uses single character lifetime names (to my knowledge, at least) and since single character lifetime names aren't incorrect. I'd be happy to change this upon request, however. Fixes rust-lang#8233.

- [x] Followed lint naming conventions
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

changelog: new lint: [`single_char_lifetime_names`]
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 13, 2022
@bors
Auto merge of rust-lang#8236 - PatchMixolydic:single_char_lifetime_na…
5991695 
…mes, r=llogiq

new lint: `single_char_lifetime_names`

This pull request adds a lint against single character lifetime names, as they might not divulge enough information about the purpose of the lifetime. This can make code harder to understand. I placed this in `restriction` rather than `pedantic` (as suggested in rust-lang#8233) since most of the Rust ecosystem already uses single character lifetime names (to my knowledge, at least) and since single character lifetime names aren't incorrect. I'd be happy to change this upon request, however. Fixes rust-lang#8233.

- [x] Followed lint naming conventions
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

changelog: new lint: [`single_char_lifetime_names`]
lnicola pushed a commit to lnicola/rust that referenced this issue Jun 23, 2024
@bors
Auto merge of rust-lang#17438 - jjoeldaniel:toggle_lsp_logs, r=Veykril
17f2596 
feat: add `toggleLSPLogs` command

Implement client-side command to toggle LSP logs in VSCode.

The command replaces the need to add/remove the `"rust-analyzer.trace.server": "verbose"` setting each time one wants to display logs. I've also updated the docs/ instances that reference the now outdated manual method.

The command labeled `rust-analyzer: Toggle LSP Logs` enables the setting project-wide and opens the relevant trace output channel.

Closes rust-lang#8233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-metadata Area: Crate metadata A-resolve Area: Name/path resolution done by `rustc_resolve` specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emberian @bblum