Skip to content

Bootstrap fails to build when switching between submodule and subtree #72104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jethrogb opened this issue May 11, 2020 · 3 comments
Open

Bootstrap fails to build when switching between submodule and subtree #72104

jethrogb opened this issue May 11, 2020 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@jethrogb
Copy link
Contributor

When switching between git trees where one contains clippy as a submodule and one contains clippy in tree, x.py fails to initialize the submodule correctly in some cases, resulting in a failed build. For example:

git clone https://github.com/jethrogb/rust/ -b clippy-submodule
cd rust
./x.py help
git checkout -f clippy-tree
./x.py help
git checkout -f -
./x.py help
error: failed to read `/tmp/rust/src/tools/clippy/Cargo.toml`

Caused by:
  No such file or directory (os error 2)
failed to run: /tmp/rust/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /tmp/rust/src/bootstrap/Cargo.toml

Full output: xpy-clippy.txt

/tmp/rust/src/tools/clippy/Cargo.toml should be in the clippy submodule but it's not checked out correctly. If I do git reset --hard inside the submodule, it works fine.

related #63964

@rustbot modify labels +A-rustbuild

@jethrogb jethrogb added the C-bug Category: This is a bug. label May 11, 2020
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2020

Error: Parsing label command in comment failed: ...'ify labels' | error: must have : or to as label starter at >| ' +A-rustbu'...

Please let @rust-lang/release know if you're having trouble with this bot.

@jethrogb
Copy link
Contributor Author

@rustbot modify labels: +A-rustbuild

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 11, 2020
@jyn514
Copy link
Member

jyn514 commented Apr 30, 2021

This will become relevant again once #82208 is merged.

@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. labels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants