Skip to content

trailing attributes should not be allowed in extern mod foo { ... } #6132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbclements opened this issue Apr 30, 2013 · 2 comments
Closed

trailing attributes should not be allowed in extern mod foo { ... } #6132

jbclements opened this issue Apr 30, 2013 · 2 comments

Comments

@jbclements
Copy link
Contributor

Currently, the parser doesn't check that the list of attributes is empty after it finishes parsing the elements in a foreign module.
@catamorphism
Copy link
Contributor

Nominating for milestone 2, backward-compatible

@ghost ghost assigned catamorphism Aug 19, 2013
@catamorphism
Copy link
Contributor

This is actually fixed. I'll check in the test case today.

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 9, 2020
@bors
Auto merge of rust-lang#6132 - rust-lang:regex-unicode, r=ebroto
171ab9b 
Fix unicode regexen with bytes::Regex

fixes rust-lang#6005

The rationale for this is that since we wrote that lint, `bytes::Regex` was extended to be able to use unicode character classes.

---

changelog: [`invalid_regex`]: allow unicode character classes in bytes regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbclements @catamorphism