Skip to content

Remove rust_exchange_alloc #5323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 12, 2013 · 4 comments
Closed

Remove rust_exchange_alloc #5323

brson opened this issue Mar 12, 2013 · 4 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 12, 2013

This is the C++ implementation of the exchange allocator. It has no users. The only thing that can't be removed yet is the global exchange_count variable.
@yichoi
Copy link
Contributor

yichoi commented Apr 30, 2013

It looks to me that rust_exchange_alloc used by reserve_vec_exact in rust_util.h,
reserve_vec_exact used by vec_reserve_shared_actual in rust_builtin.cpp. and so forth.

Does it really has no users ?

@graydon
Copy link
Contributor

graydon commented Apr 30, 2013

Yeah, the vec paths still use it

@thestinger
Copy link
Contributor

I moved the vector reserve for exchange allocations to libstd, so there's not much left using this. I removed the exchange_count atomic counting because valgrind covers this well and we have valgrind bots on auto. It's a noticeable performance hit since it results in a cache miss.

@thestinger thestinger mentioned this issue Aug 2, 2013
Closed
@thestinger
Copy link
Contributor

This is completed.

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5323 - rabisg0:fix/5284, r=flip1995
0e5e2c4 
Improvement: Don't show function body in needless_lifetimes

Changes the span on which the lint is reported to point to only the
function return type instead of the entire function body.
Fixes rust-lang#5284

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @brson @thestinger @yichoi