Skip to content

1.26 Release notes document unstable nightly cargo feature #51091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ehuss opened this issue May 26, 2018 · 3 comments · Fixed by #51507
Closed

1.26 Release notes document unstable nightly cargo feature #51091

ehuss opened this issue May 26, 2018 · 3 comments · Fixed by #51507
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented May 26, 2018

The release notes for 1.26 mention Cargo.lock files are now included in published crates. but that is a nightly-only unstable feature. Was that intentional?

@est31
Copy link
Member

est31 commented May 26, 2018

cc @Aaronepower

@kennytm kennytm added C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels May 26, 2018
@XAMPPRocky
Copy link
Member

XAMPPRocky commented May 31, 2018

Yes this seems unintentional, which is odd since it was marked relnotes and unstable features tend not to get that tag. cc @rust-lang/cargo would anyone be able to clarify cargo/5093?

@alexcrichton
Copy link
Member

rust-lang/cargo#5093 was initially intended for stable but through testing we ended up realizing it would be a breaking change and is not always desirable. Instead of stabilizing it rust-lang/cargo#5093 was landed as a nightly feature, guarded by cargo-features = ["publish-lockfile"] in the manifest

XAMPPRocky pushed a commit to XAMPPRocky/rust that referenced this issue Jun 11, 2018
bors added a commit that referenced this issue Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants