Skip to content

doc/style/changing directory is outdated. #29077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Havvy opened this issue Oct 15, 2015 · 3 comments
Closed

doc/style/changing directory is outdated. #29077

Havvy opened this issue Oct 15, 2015 · 3 comments

Comments

@Havvy
Copy link
Contributor

Havvy commented Oct 15, 2015

The directory https://github.com/rust-lang/rust/tree/master/src/doc/style/changing has a pre-1.0 page attached to it, and the post-1.0 page talks about higher kinded types.

Given that nobody's mentioned this yet, I don't think this chapter of the style guide is even useful, and should be fully axed.
@Havvy
Copy link
Contributor Author

Havvy commented Oct 15, 2015

cc @steveklabnik

@steveklabnik
Copy link
Member

We generally imported @aturon's stuff wholesale, and not a lot has been done with it. So yeah, I would imagine this section should probably just go.

@Havvy Havvy mentioned this issue Oct 15, 2015
Merged
@Havvy
Copy link
Contributor Author

Havvy commented Oct 15, 2015

Closing in favor of PR.

@Havvy Havvy closed this as completed Oct 15, 2015
Manishearth added a commit to Manishearth/rust that referenced this issue Oct 16, 2015
@Manishearth
Rollup merge of rust-lang#29080 - Havvy:remove_doc_style_changing, r=…
5fab28a 
…alexcrichton

Fixes issue rust-lang#29077.

There **are** API changing guidelines in the RFCs, so it might be prudent to put those there. But I'm leaving that up to another person. This PR just removes bad documentation.
bors added a commit that referenced this issue Oct 16, 2015
@bors
Auto merge of #29080 - Havvy:remove_doc_style_changing, r=alexcrichton
d5a777c 
Fixes issue #29077.

There **are** API changing guidelines in the RFCs, so it might be prudent to put those there. But I'm leaving that up to another person. This PR just removes bad documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steveklabnik @Havvy